Fix: Initial index update on empty userModel

#41

Prevent initial call to selector.userChanged() if the userModel is
empty.

Author: uiriansan

README.md

@@ -76,12 +76,6 @@ git clone -b main --depth=1 https://github.com/uiriansan/SilentSDDM && cd Silent
 > [!IMPORTANT]
 > Make sure to test the theme before rebooting by running `./test.sh`, otherwise you might end up with a broken login screen. Refer to the [snippets page](https://github.com/uiriansan/SilentSDDM/wiki/Snippets) if something goes wrong and [open an issue](https://github.com/uiriansan/SilentSDDM/issues/new/choose) if you don't find the solution there.
 
-> [!NOTE]
-> If you encounter issues with the login screen not updating after changes, try clearing SDDM's cache:
-> ```bash
-> sudo rm -rf /var/lib/sddm/.cache
-> ```
-
 ## AUR packages for Arch
 If you run Arch Linux, consider installing one of the AUR packages:
 ```bash

components/LoginScreen.qml

@@ -320,7 +320,7 @@ Item {
                     enabled: loginScreen.state !== "selectingUser" && loginScreen.state !== "authenticating"
                     activeFocusOnTab: true
                     icon: Config.getIcon(Config.loginButtonIcon)
-                    label: textConstants.login ? textConstants.login.toUpperCase() : "LOGIN"
+                    label: textConstants.login ? textConstants.login : "Login"
                     showLabel: Config.loginButtonShowTextIfNoPassword && !loginScreen.userNeedsPassword
                     tooltipText: !Config.tooltipsDisableLoginButton && (!Config.loginButtonShowTextIfNoPassword || loginScreen.userNeedsPassword) ? (textConstants.login || "Login") : ""
                     iconSize: Config.loginButtonIconSize

components/UserSelector.qml

@@ -47,13 +47,15 @@ Item {
         model: userModel
         currentIndex: userModel.lastIndex
         onCurrentIndexChanged: {
-            var username = userModel.data(userModel.index(currentIndex, 0), 257);
-            var userRealName = userModel.data(userModel.index(currentIndex, 0), 258);
-            var userIcon = userModel.data(userModel.index(currentIndex, 0), 260);
-            var needsPasswd = userModel.data(userModel.index(currentIndex, 0), 261);
+            if (loginScreen.foundUsers) {
+                var username = userModel.data(userModel.index(currentIndex, 0), 257);
+                var userRealName = userModel.data(userModel.index(currentIndex, 0), 258);
+                var userIcon = userModel.data(userModel.index(currentIndex, 0), 260);
+                var needsPasswd = userModel.data(userModel.index(currentIndex, 0), 261);
 
-            sddm.currentUser = username;
-            selector.userChanged(currentIndex, username, userRealName, userIcon, needsPasswd);
+                sddm.currentUser = username;
+                selector.userChanged(currentIndex, username, userRealName, userIcon, needsPasswd);
+            }
         }
 
         delegate: Rectangle {

docs/Snippets.md

@@ -34,7 +34,7 @@ sudoedit /etc/pam.d/sddm
     auth        include     system-login
 ```
 
-The theme should now hide the password input if you select the user. You can test this by running `./test`.
+The theme should now hide the password input if you select the user. You can test this by running `./test.sh`.
 
 # Change user face (avatar)
 There is a script included with the theme:
@@ -73,4 +73,10 @@ sudoedit /etc/sddm.conf
 
     # Append `LIBVA_DRIVER_NAME=` and `QT_MULTIMEDIA_PREFERRED_PLUGINS=` to the end of the line:
     GreeterEnvironment=QML2_IMPORT_PATH=/usr/share/sddm/themes/silent/components/,QT_IM_MODULE=qtvirtualkeyboard,LIBVA_DRIVER_NAME=,QT_MULTIMEDIA_PREFERRED_PLUGINS=
-```
+```
+
+# Fix theme not updating after changes or SDDM loading fallback theme with errors:
+Try clearing SDDM's cache:
+```bash
+sudo rm -rf /var/lib/sddm/.cache
+```