fix(translate): prevent NPE translating words during ASR re-run

Author: umlx5h

FlyleafLib/MediaPlayer/Translation/SubtitlesTranslator.cs

@@ -22,6 +22,8 @@ public class SubTranslator
     private readonly TranslateServiceFactory _translateServiceFactory;
     private Task? _translateTask;
     private bool _isReset;
+    private Language? _srcLang;
+
     private bool IsEnabled => _config[_subIndex].EnabledTranslated;
 
     private readonly LogHandler Log;
@@ -55,6 +57,12 @@ private void SubManager_OnPropertyChanged(object? sender, PropertyChangedEventAr
                 if (!IsEnabled || _subManager.Subs.Count == 0 || _subManager.Language == null)
                     return;
 
+                if (_translateService == null)
+                {
+                    // capture for later initialization
+                    _srcLang = _subManager.Language;
+                }
+
                 if (_translationStartCancellation != null)
                 {
                     _translationStartCancellation.Cancel();
@@ -116,6 +124,7 @@ private async Task Reset()
 
             _translateService?.Dispose();
             _translateService = null;
+            _srcLang = null;
         }
         finally
         {
@@ -199,7 +208,7 @@ private void EnsureTranslationService()
             if (_translateService == null)
             {
                 var service = _translateServiceFactory.GetService(_config.TranslateServiceType, false);
-                service.Initialize(_subManager.Language, _config.TranslateTargetLanguage);
+                service.Initialize(_srcLang!, _config.TranslateTargetLanguage);
 
                 Volatile.Write(ref _translateService, service);
             }

LLPlayer/Controls/WordPopup.xaml.cs

@@ -195,8 +195,8 @@ private async ValueTask<string> TranslateWithCache(string text, WordClickedEvent
         var srcLang = FL.Player.SubtitlesManager[e.SubIndex].Language;
         var targetLang = FL.PlayerConfig.Subtitles.TranslateTargetLanguage;
 
-        // Same language
-        if (srcLang?.ISO6391 == targetLang.ToISO6391())
+        // Not set language or same language
+        if (srcLang == null || srcLang.ISO6391 == targetLang.ToISO6391())
         {
             return text;
         }