Merge pull request #1655 from baranowb/UNDERTOW-2431_max

[UNDERTOW-2431] Bump jboss-parent to 46, checkstyle and slightly upda…

Author: baranowb

core/src/main/java/io/undertow/UndertowLogger.java

@@ -81,7 +81,7 @@ public interface UndertowLogger extends BasicLogger {
 
 //    @LogMessage(level = INFO)
 //    @Message(id = 5002, value = "Exception reading file %s: %s")
-//    void exceptionReadingFile(final Path file, final IOException e);
+//    void exceptionReadingFile(Path file, IOException e);
 
     @LogMessage(level = ERROR)
     @Message(id = 5003, value = "IOException reading from channel")
@@ -101,15 +101,15 @@ public interface UndertowLogger extends BasicLogger {
 
     @LogMessage(level = DEBUG)
     @Message(id = 5008, value = "An invalid token '%s' with value '%s' has been received.")
-    void invalidTokenReceived(final String tokenName, final String tokenValue);
+    void invalidTokenReceived(String tokenName, String tokenValue);
 
     @LogMessage(level = DEBUG)
     @Message(id = 5009, value = "A mandatory token %s is missing from the request.")
-    void missingAuthorizationToken(final String tokenName);
+    void missingAuthorizationToken(String tokenName);
 
     @LogMessage(level = DEBUG)
     @Message(id = 5010, value = "Verification of authentication tokens for user '%s' has failed using mechanism '%s'.")
-    void authenticationFailed(final String userName, final String mechanism);
+    void authenticationFailed(String userName, String mechanism);
 
     @LogMessage(level = ERROR)
     @Message(id = 5011, value = "Ignoring AJP request with prefix %s")
@@ -443,23 +443,23 @@ void nodeConfigCreated(URI connectionURI, String balancer, String domain, String
 
     @LogMessage(level = DEBUG)
     @Message(id = 5096, value = "Authentication failed for digest header %s in %s")
-    void authenticationFailedFor(final String header, final HttpServerExchange exchange, final @Cause Exception e);
+    void authenticationFailedFor(String header, HttpServerExchange exchange, @Cause Exception e);
 
     @LogMessage(level = DEBUG)
     @Message(id = 5097, value = "Failed to obtain subject for %s")
-    void failedToObtainSubject(final HttpServerExchange exchange, final @Cause GeneralSecurityException e);
+    void failedToObtainSubject(HttpServerExchange exchange, @Cause GeneralSecurityException e);
 
     @LogMessage(level = DEBUG)
     @Message(id = 5098, value = "GSSAPI negotiation failed for %s")
-    void failedToNegotiateAtGSSAPI(final HttpServerExchange exchange, final @Cause Throwable e);
+    void failedToNegotiateAtGSSAPI(HttpServerExchange exchange, @Cause Throwable e);
 
     @LogMessage(level = WARN)
     @Message(id = 5099, value = "Failed to create SSO for session '%s'")
-    void failedToCreateSSOForSession(final String sessionId);
+    void failedToCreateSSOForSession(String sessionId);
 
     @LogMessage(level = DEBUG)
     @Message(id = 5100, value = "Failed to list paths for '%s'")
-    void failedToListPathsForFile(final Path f);
+    void failedToListPathsForFile(Path f);
 
     @LogMessage(level = DEBUG)
     @Message(id = 5101, value = "No source to list resources from")

core/src/main/java/io/undertow/UndertowMessages.java

@@ -85,7 +85,7 @@ public interface UndertowMessages {
     IllegalStateException sessionManagerNotFound();
 
     @Message(id = 13, value = "Argument %s cannot be null")
-    IllegalArgumentException argumentCannotBeNull(final String argument);
+    IllegalArgumentException argumentCannotBeNull(String argument);
 
 //    @Message(id = 14, value = "close() called with data still to be flushed. Please call shutdownWrites() and then call flush() until it returns true before calling close()")
 //    IOException closeCalledWithDataStillToBeFlushed();
@@ -112,13 +112,13 @@ public interface UndertowMessages {
     IllegalArgumentException hashAlgorithmNotFound(String algorithmName);
 
     @Message(id = 23, value = "An invalid Base64 token has been received.")
-    IllegalArgumentException invalidBase64Token(@Cause final IOException cause);
+    IllegalArgumentException invalidBase64Token(@Cause IOException cause);
 
     @Message(id = 24, value = "An invalidly formatted nonce has been received.")
     IllegalArgumentException invalidNonceReceived();
 
     @Message(id = 25, value = "Unexpected token '%s' within header.")
-    IllegalArgumentException unexpectedTokenInHeader(final String name);
+    IllegalArgumentException unexpectedTokenInHeader(String name);
 
     @Message(id = 26, value = "Invalid header received.")
     IllegalArgumentException invalidHeader();
@@ -133,10 +133,10 @@ public interface UndertowMessages {
     IOException chunkedChannelClosedMidChunk();
 
     @Message(id = 30, value = "User %s successfully authenticated.")
-    String userAuthenticated(final String userName);
+    String userAuthenticated(String userName);
 
     @Message(id = 31, value = "User %s has logged out.")
-    String userLoggedOut(final String userName);
+    String userLoggedOut(String userName);
 //
 //    @Message(id = 33, value = "Authentication type %s cannot be combined with %s")
 //    IllegalStateException authTypeCannotBeCombined(String type, String existing);
@@ -154,7 +154,7 @@ public interface UndertowMessages {
     RuntimeException failedToParsePath();
 
     @Message(id = 38, value = "Authentication failed, requested user name '%s'")
-    String authenticationFailed(final String userName);
+    String authenticationFailed(String userName);
 
     @Message(id = 39, value = "Too many query parameters, cannot have more than %s query parameters")
     BadRequestException tooManyQueryParameters(int noParams);

core/src/main/java/io/undertow/attribute/ExchangeAttribute.java

@@ -33,13 +33,13 @@ public interface ExchangeAttribute {
      * @param exchange The exchange
      * @return The attribute
      */
-    String readAttribute(final HttpServerExchange exchange);
+    String readAttribute(HttpServerExchange exchange);
 
     /**
      * Sets a new value for the attribute. Not all attributes are writable.
      * @param exchange The exchange
      * @param newValue The new value for the attribute
      * @throws  ReadOnlyAttributeException when attribute cannot be written
      */
-    void writeAttribute(final HttpServerExchange exchange, final String newValue) throws ReadOnlyAttributeException;
+    void writeAttribute(HttpServerExchange exchange, String newValue) throws ReadOnlyAttributeException;
 }

core/src/main/java/io/undertow/attribute/ExchangeAttributeBuilder.java

@@ -41,7 +41,7 @@ public interface ExchangeAttributeBuilder {
      * @param token The string token
      * @return The exchange attribute, or null
      */
-    ExchangeAttribute build(final String token);
+    ExchangeAttribute build(String token);
 
     /**
      * The priority of the builder. Builders will be tried in priority builder. Built in builders use the priority range 0-100,

core/src/main/java/io/undertow/client/ClientConnection.java

@@ -56,7 +56,7 @@ public interface ClientConnection extends Channel {
      *
      * @param request The request to send.
      */
-    void sendRequest(final ClientRequest request, final ClientCallback<ClientExchange> clientCallback);
+    void sendRequest(ClientRequest request, ClientCallback<ClientExchange> clientCallback);
 
     /**
      * Upgrade the connection, if the underlying protocol supports it. This should only be called after an upgrade request

core/src/main/java/io/undertow/client/ClientExchange.java

@@ -27,9 +27,9 @@
  */
 public interface ClientExchange extends Attachable {
 
-    void setResponseListener(final ClientCallback<ClientExchange> responseListener);
+    void setResponseListener(ClientCallback<ClientExchange> responseListener);
 
-    void setContinueHandler(final ContinueNotification continueHandler);
+    void setContinueHandler(ContinueNotification continueHandler);
 
     void setPushHandler(PushCallback pushCallback);
 

core/src/main/java/io/undertow/client/ClientProvider.java

@@ -38,12 +38,12 @@ public interface ClientProvider {
 
     Set<String> handlesSchemes();
 
-    void connect(final ClientCallback<ClientConnection> listener, final URI uri, final XnioWorker worker, XnioSsl ssl, ByteBufferPool bufferPool, OptionMap options);
+    void connect(ClientCallback<ClientConnection> listener, URI uri, XnioWorker worker, XnioSsl ssl, ByteBufferPool bufferPool, OptionMap options);
 
-    void connect(final ClientCallback<ClientConnection> listener, InetSocketAddress bindAddress, final URI uri, final XnioWorker worker, XnioSsl ssl, ByteBufferPool bufferPool, OptionMap options);
+    void connect(ClientCallback<ClientConnection> listener, InetSocketAddress bindAddress, URI uri, XnioWorker worker, XnioSsl ssl, ByteBufferPool bufferPool, OptionMap options);
 
-    void connect(final ClientCallback<ClientConnection> listener, final URI uri, final XnioIoThread ioThread, XnioSsl ssl, ByteBufferPool bufferPool, OptionMap options);
+    void connect(ClientCallback<ClientConnection> listener, URI uri, XnioIoThread ioThread, XnioSsl ssl, ByteBufferPool bufferPool, OptionMap options);
 
-    void connect(final ClientCallback<ClientConnection> listener, InetSocketAddress bindAddress, final URI uri, final XnioIoThread ioThread, XnioSsl ssl, ByteBufferPool bufferPool, OptionMap options);
+    void connect(ClientCallback<ClientConnection> listener, InetSocketAddress bindAddress, URI uri, XnioIoThread ioThread, XnioSsl ssl, ByteBufferPool bufferPool, OptionMap options);
 
 }

core/src/main/java/io/undertow/client/UndertowClientMessages.java

@@ -46,7 +46,7 @@ public interface UndertowClientMessages {
 
     // 1020
     @Message(id = 1020, value = "Failed to upgrade channel due to response %s (%s)")
-    String failedToUpgradeChannel(final int responseCode, String reason);
+    String failedToUpgradeChannel(int responseCode, String reason);
 
     // 1030
     @Message(id = 1030, value = "invalid content length %d")

core/src/main/java/io/undertow/conduits/AbstractFramedStreamSinkConduit.java

@@ -256,7 +256,7 @@ public interface FrameCallBack {
 
         void done();
 
-        void failed(final IOException e);
+        void failed(IOException e);
 
     }
 

core/src/main/java/io/undertow/io/BufferWritableOutputStream.java

@@ -30,9 +30,9 @@
  */
 public interface BufferWritableOutputStream {
 
-    void write(final ByteBuffer[] buffers) throws IOException;
+    void write(ByteBuffer[] buffers) throws IOException;
 
-    void write(final ByteBuffer byteBuffer) throws IOException;
+    void write(ByteBuffer byteBuffer) throws IOException;
 
     void transferFrom(FileChannel source) throws IOException;