Skip to content

Commit e57700f

Browse files
authored
Merge pull request #44 from uos/cleanup-cmake
Cleanup CMake + Remove Nabo
2 parents f0b6ac7 + bf8fde6 commit e57700f

29 files changed

+24
-97
lines changed

CMakeLists.txt

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -339,15 +339,6 @@ if(BUILD_VIEWER)
339339
endif()
340340
endif(BUILD_VIEWER)
341341

342-
#------------------------------------------------------------------------------
343-
# Searching for NABO
344-
#------------------------------------------------------------------------------
345-
find_package(Nabo)
346-
if(Nabo_FOUND)
347-
include_directories(${Nabo_INCLUDE_DIRS})
348-
list(APPEND LVR2_DEFINITIONS -DLVR2_USE_NABO)
349-
endif(Nabo_FOUND)
350-
351342
#------------------------------------------------------------------------------
352343
## Searching for PCL
353344
#------------------------------------------------------------------------------
@@ -376,6 +367,7 @@ endif(WITH_PCL)
376367
#------------------------------------------------------------------------------
377368
# Searching CGAL
378369
#------------------------------------------------------------------------------
370+
set(CGAL_DATA_DIR ".")
379371
find_package(CGAL)
380372
if(CGAL_FOUND)
381373

@@ -827,7 +819,6 @@ install(FILES package.xml DESTINATION share/lvr2)
827819
install(FILES
828820
CMakeModules/FindFLANN.cmake
829821
CMakeModules/FindLZ4.cmake
830-
CMakeModules/FindNabo.cmake
831822
CMakeModules/FindOpenNI.cmake
832823
CMakeModules/FindOpenNI2.cmake
833824
CMakeModules/FindQVTK.cmake

CMakeModules/FindNabo.cmake

Lines changed: 0 additions & 12 deletions
This file was deleted.

LVR2Config.cmake.in

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -141,12 +141,6 @@ if(@VTK_FOUND@)
141141
list(APPEND LVR2_DEFINITIONS ${VTK_DEFINITIONS})
142142
endif()
143143

144-
# nabo
145-
if(@NABO_FOUND@)
146-
find_package(Nabo REQUIRED)
147-
list(APPEND LVR2_INCLUDE_DIRS ${NABO_INCLUDE_DIRS})
148-
endif()
149-
150144
# pcl
151145
if(@PCL_FOUND@)
152146
find_package(PCL REQUIRED)

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ Supported options:
177177
automatically.
178178
-p [ --pcm ] arg (=LVR2) Point cloud manager used for point
179179
handling and normal estimation. Choose
180-
from {FLANN, PCL, NABO, LVR2, LBVH_CUDA}.
180+
from {FLANN, PCL, LVR2, LBVH_CUDA}.
181181
--nem arg (=0) Method for estimating point normals /
182182
planes. 0: PCA (default), 1: RANSAC, 2:
183183
IPCA ilikebigbits, 3: IPCA exact. Make

ext/spdlog/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ if(SPDLOG_BUILD_PIC)
148148
endif()
149149

150150
find_package(Threads REQUIRED)
151-
message(STATUS "Build type: " ${CMAKE_BUILD_TYPE})
151+
# message(STATUS "Build type: " ${CMAKE_BUILD_TYPE})
152152
# ---------------------------------------------------------------------------------------
153153
# Static/Shared library
154154
# ---------------------------------------------------------------------------------------

ext/spdmon/CMakeLists.txt

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ set(CXX_STANDARD 17)
2121
include(cmake/StandardSettings.cmake)
2222
include(cmake/Utils.cmake)
2323
include(cmake/cpplint.cmake)
24-
message(STATUS "Started CMake for ${PROJECT_NAME} v${PROJECT_VERSION}...\n")
24+
message(STATUS "Build ${PROJECT_NAME}: v${PROJECT_VERSION}")
2525

2626

2727
# add every sub directory of the current source dir if it contains a CMakeLists.txt
@@ -135,7 +135,7 @@ function (ListToString result delim)
135135
set(${result} "${temp}" PARENT_SCOPE)
136136
endfunction(ListToString)
137137

138-
message(STATUS "Added all header and implementation files.\n")
138+
# message(STATUS "Added all header and implementation files.")
139139

140140
#
141141
# Set the project standard and warnings
@@ -147,7 +147,7 @@ else()
147147
target_compile_features(${PROJECT_NAME} PUBLIC cxx_std_17)
148148
endif()
149149

150-
verbose_message("Applied compiler warnings. Using standard ${CXX_STANDARD}.\n")
150+
# verbose_message("Applied compiler warnings. Using standard ${CXX_STANDARD}.")
151151

152152
#
153153
# Enable Doxygen
@@ -190,7 +190,7 @@ else()
190190
endif()
191191
endif()
192192

193-
message(STATUS "Finished setting up include directories.")
193+
# message(STATUS "Finished setting up include directories.")
194194

195195
#
196196
# Model project dependencies
@@ -208,7 +208,7 @@ message(STATUS "Finished setting up include directories.")
208208
# ${PROJECT_NAME}_PROJECT_WARNINGS
209209
#)
210210

211-
verbose_message("Successfully added all dependencies and linked against them.")
211+
# verbose_message("Successfully added all dependencies and linked against them.")
212212

213213
#
214214
# Provide alias to library for
@@ -220,7 +220,7 @@ else()
220220
add_library(${PROJECT_NAME}::${PROJECT_NAME} ALIAS ${PROJECT_NAME})
221221
endif()
222222

223-
verbose_message("Project is now aliased as ${PROJECT_NAME}::${PROJECT_NAME}.\n")
223+
# verbose_message("Project is now aliased as ${PROJECT_NAME}::${PROJECT_NAME}.")
224224

225225
#
226226
# Format the project using the `clang-format` target (i.e: cmake --build build --target clang-format)
@@ -311,8 +311,8 @@ if(${PROJECT_NAME}_GENERATE_EXPORT_HEADER)
311311
include
312312
)
313313

314-
message(STATUS "Generated the export header `${PROJECT_NAME_LOWERCASE}_export.h` and installed it.")
314+
# message(STATUS "Generated the export header `${PROJECT_NAME_LOWERCASE}_export.h` and installed it.")
315315
endif()
316316

317-
message(STATUS "Finished building requirements for installing the package.\n")
317+
# message(STATUS "Finished building requirements for installing the package.\n")
318318

ext/spdmon/cmake/Utils.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ function(add_clang_format_target)
3434
-i ${ALL_CXX_SOURCE_FILES})
3535
endif()
3636

37-
message(STATUS "Format the project using the `clang-format` target (i.e: cmake --build build --target clang-format).\n")
37+
# message(STATUS "Format the project using the `clang-format` target (i.e: cmake --build build --target clang-format).\n")
3838
endif()
3939
endfunction(add_clang_format_target)
4040

ext/spdmon/cmake/cpplint.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,6 @@ function(add_cpplint_style_check_target)
8282
VERBATIM)
8383

8484

85-
message(STATUS "Format the project using the `cpplint` target (i.e: cmake --build build --target cpplint-format).\n")
85+
# message(STATUS "Format the project using the `cpplint` target (i.e: cmake --build build --target cpplint-format).\n")
8686
endif()
8787
endfunction(add_cpplint_style_check_target)

include/lvr2/reconstruction/AdaptiveKSearchSurface.hpp

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -64,11 +64,6 @@
6464
// #include "SearchTreeFlannPCL.hpp"
6565
// #endif
6666

67-
// // SearchTreeNabo
68-
// #ifdef LVR2_USE_NABO
69-
// #include "SearchTreeNabo.hpp"
70-
// #endif
71-
7267
using std::numeric_limits;
7368
using std::string;
7469
using std::unique_ptr;

src/tools/lvr2_dmc_reconstruction/Main.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,9 +54,8 @@ PointsetSurfacePtr<BaseVecT> loadPointCloud(const dmc_reconstruction::Options& o
5454
std::cout << timestamp << "Using PCL as point cloud manager is not implemented yet!" << std::endl;
5555
panic_unimplemented("PCL as point cloud manager");
5656
}
57-
else if(pcm_name == "FLANN" || pcm_name == "NABO" || pcm_name == "NANOFLANN")
57+
else if(pcm_name == "FLANN" || pcm_name == "NANOFLANN")
5858
{
59-
6059
int plane_fit_method = 0;
6160

6261
if(options.useRansac())

0 commit comments

Comments
 (0)