feat: Update callers of to server.Serve to use buffered channel to avoid deadlocks when callers are not listening to the ready channel

Author: ventsip

cmd/cli/main.go

@@ -54,7 +54,7 @@ func main() {
 	wg.Add(1)
 	go ph.Run(ctx, &wg)
 	wg.Add(1)
-	go server.Serve(ctx, &wg, ph, version, make(chan<- struct{}))
+	go server.Serve(ctx, &wg, ph, version, make(chan<- struct{}, 1))
 	wg.Wait()
 
 	if err := ph.SaveBalance(); err != nil {

cmd/winsvc/service.go

@@ -117,7 +117,7 @@ func (m *myservice) Execute(args []string, r <-chan svc.ChangeRequest, changes c
 				wg.Add(1)
 				go ph.Run(ctx, &wg)
 				wg.Add(1)
-				go server.Serve(ctx, &wg, ph, version, make(chan<- struct{}))
+				go server.Serve(ctx, &wg, ph, version, make(chan<- struct{}, 1))
 				changes <- svc.Status{State: svc.Running, Accepts: cmdsAccepted}
 
 			default:

server/server.go

@@ -131,14 +131,15 @@ func Serve(ctx context.Context, wg *sync.WaitGroup, ph *engine.ProcessHunter, ve
 	log.Println("starting service")
 	go func() {
 		if err := s.ListenAndServe(); err != nil && err != http.ErrServerClosed {
-			log.Fatalf("Web service listen error: %s", err)
+			log.Println("Web service listen error:", err)
 		}
 	}()
 
 	ready <- struct{}{} // signal that the server is ready
 
 	<-ctx.Done()
 
+	log.Println("Web service shutting down")
 	ctx, cancel := context.WithTimeout(context.Background(), 3*time.Second)
 	defer cancel()
 	err := s.Shutdown(ctx)