Topscope variables may be facts, but may also be top scope variables

[SimonHoenscheid]

running the check with --fix on a manifest with lots of top scope variables shows the puppet lint check changes every variable into a fact.

solution: provide a list of facts

[bastelfreak]

I'm wondering if we should disable fact manipulation in this plugin. We've https://github.com/mmckinst/puppet-lint-legacy_facts-check which should already fix it and puppetlabs/puppet-lint#41 mentioneds that both plugins conflict. CC: @ekohl @alexjfisher

[alexjfisher]

@SimonHoenscheid Is this filed in the right place? I don't think this plugin is the one responsible for changing variables into 'facts'. We have got some conflicting behaviour between plugins though. Maybe this can be fixed by changing the order that plugins are run? I assume it's alphabetical in some way (but is that filename, or check name)???

[SimonHoenscheid]

@alexjfisher I talked to @bastelfreak before opening this issue, because I was not sure, but the behavior of the lint check is dangerous.

[alexjfisher]

@SimonHoenscheid Maybe we're talking cross purposes. Could you explain exactly what you mean by changes every variable into a fact.?

I'm wondering if you're actually encountering mmckinst/puppet-lint-top_scope_facts-check#10

[SimonHoenscheid]

@alexjfisher If I memorize it correct yes. I am not sure, but I can try to replicate.