chore: update typescript-eslint packages (#4696)

Author: brunozoric

.cursorignore

@@ -0,0 +1,7 @@
+# Add directories or file patterns to ignore during indexing (e.g. foo/ or *.csv)
+.env
+.env.*
+.pulumi/*
+.idea/*
+.webiny/*
+.coverage/*

.eslintrc.js

@@ -45,7 +45,7 @@ module.exports = {
                 "ts-expect-error": false
             }
         ],
-        //"@typescript-eslint/no-restricted-types": "error",
+        "@typescript-eslint/no-restricted-types": "error",
         "@typescript-eslint/no-use-before-define": 0,
         "@typescript-eslint/no-unused-vars": getNoUnusedVars(),
         "@typescript-eslint/no-var-requires": 0,
@@ -71,9 +71,9 @@ module.exports = {
                     }
                 ]
             }
-        ]
-        // TODO remove eventually in v6.0.0
-        //"@typescript-eslint/no-require-imports": 0
+        ],
+        "@typescript-eslint/no-unused-expressions": 0,
+        "@typescript-eslint/no-require-imports": 0
     },
     settings: {
         react: {

cypress-tests/cypress/support/pageBuilder/reloadUntil.ts

@@ -54,7 +54,7 @@ Cypress.Commands.add("reloadUntil", (callback, options = {}) => {
                         }
                     }
                     return cy.log("Condition met, moving on...");
-                } catch (err) {
+                } catch {
                     if (retries > MAX_RETRIES) {
                         throw new Error(`retried too many times (${--retries})`);
                     }

cypress-tests/cypress/support/reloadUntil/index.js

@@ -43,7 +43,7 @@ Cypress.Commands.add("reloadUntil", (callback, options = {}) => {
                         }
                     }
                     return cy.log("Condition met, moving on...");
-                } catch (err) {
+                } catch {
                     if (retries > MAX_RETRIES) {
                         throw new Error(`retried too many times (${--retries})`);
                     }

package.json

@@ -73,8 +73,8 @@
     "@types/prettier": "^2.7.3",
     "@types/react": "18.2.79",
     "@types/react-dom": "18.2.25",
-    "@typescript-eslint/eslint-plugin": "^7.18.0",
-    "@typescript-eslint/parser": "^7.18.0",
+    "@typescript-eslint/eslint-plugin": "^8.39.1",
+    "@typescript-eslint/parser": "^8.39.1",
     "adio": "^1.0.1",
     "axios": "^1.7.9",
     "babel-jest": "29.7.0",

packages/admin-ui/src/Tree/components/ItemContent.tsx

@@ -1,7 +1,7 @@
 import React from "react";
 import { cn, makeDecoratable } from "~/utils";
 
-interface ItemContentProps extends React.HTMLAttributes<HTMLDivElement> {}
+export type ItemContentProps = React.HTMLAttributes<HTMLDivElement>;
 
 const BaseItemContent = ({ children, className, ...props }: ItemContentProps) => {
     return (
@@ -17,6 +17,4 @@ const BaseItemContent = ({ children, className, ...props }: ItemContentProps) =>
     );
 };
 
-const ItemContent = makeDecoratable("TreeItemContent", BaseItemContent);
-
-export { ItemContent, type ItemContentProps };
+export const ItemContent = makeDecoratable("TreeItemContent", BaseItemContent);

packages/admin-ui/src/Tree/presenters/TreePresenter.ts

@@ -69,7 +69,7 @@ class TreePresenter<TData = unknown> implements ITreePresenter<TData> {
                     data: item.data
                 })
             );
-        } catch (error) {
+        } catch {
             this.nodes = [...oldNodes]; // Revert to old nodes in case of error
         }
     };

packages/api-apw/src/plugins/hooks/validateComment.ts

@@ -21,7 +21,7 @@ export const validateComment = ({ apw }: Pick<LifeCycleHookCallbackParams, "apw"
                     }
                 );
             }
-        } catch (ex) {
+        } catch {
             throw new WebinyError(
                 `The"changeRequest" property in input is not properly formatted.`,
                 "MALFORMED_CHANGE_REQUEST_ID",

packages/api-elasticsearch-tasks/src/tasks/createIndexes/createIndex.ts

@@ -11,7 +11,7 @@ export const createIndexFactory = (manager: IndexManager) => {
                 if (exists) {
                     return;
                 }
-            } catch (ex) {
+            } catch {
                 return;
             }
 

packages/api-elasticsearch-tasks/src/tasks/dataSynchronization/entities/getElasticsearchEntity.ts

@@ -33,7 +33,7 @@ export const getElasticsearchEntity = (params: IGetElasticsearchEntityParams) =>
             case EntityType.FORM_BUILDER_SUBMISSION:
                 return getByPredicate(createPredicate("fb", ["es", "form-submission"]));
         }
-    } catch (ex) {}
+    } catch {}
     throw new Error(`Unknown entity type "${type}".`);
 };