fix

Author: theofidry

src/ParallelCommand.php

@@ -13,7 +13,6 @@
 
 namespace Webmozarts\Console\Parallelization;
 
-use Closure;
 use Symfony\Bundle\FrameworkBundle\Console\Application as FrameworkBundleApplication;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\InputDefinition;
@@ -30,13 +29,10 @@
 use Webmozarts\Console\Parallelization\Logger\DebugProgressBarFactory;
 use Webmozarts\Console\Parallelization\Logger\Logger;
 use Webmozarts\Console\Parallelization\Logger\StandardLogger;
+use function func_get_args;
 
 abstract class ParallelCommand extends Command
 {
-    use Parallelization;
-    // TODO: simply add the Parallelization trait for 3.x where all the BC
-    //  layer of the trait is removed.
-
     protected function configure(): void
     {
         ParallelizationInput::configureCommand($this);
@@ -125,14 +121,15 @@ protected function getParallelExecutableFactory(
         InputDefinition $commandDefinition,
         ErrorHandler $errorHandler
     ): ParallelExecutorFactory {
-        return ParallelExecutorFactory::create(
-            Closure::fromCallable($fetchItems),
-            Closure::fromCallable($runSingleCommand),
-            Closure::fromCallable($getItemName),
-            $commandName,
-            $commandDefinition,
-            $errorHandler,
-        );
+        // If you are looking at this code to wonder if you should call it when
+        // overriding this method, it is highly recommended you don't and just
+        // call `ParallelExecutorFactory::create(...func_get_args())`.
+        //
+        // Configuring the factory is recommended to be done in
+        // ::configureParallelExecutableFactory() instead which is
+        // simpler to override, unless you _really_ need one of the
+        // parameters passed to this method.
+        return ParallelExecutorFactory::create(...func_get_args());
     }
 
     /**

src/Parallelization.php

@@ -146,7 +146,9 @@ protected function getParallelExecutableFactory(
         // call `ParallelExecutorFactory::create(...func_get_args())`.
         //
         // Configuring the factory is recommended to be done in
-        // ::configureParallelExecutableFactory() instead.
+        // ::configureParallelExecutableFactory() instead which is
+        // simpler to override, unless you _really_ need one of the
+        // parameters passed to this method.
         return ParallelExecutorFactory::create(...func_get_args())
             ->withRunBeforeFirstCommand($this->runBeforeFirstCommand(...))
             ->withRunAfterLastCommand($this->runAfterLastCommand(...))
@@ -172,11 +174,11 @@ protected function configureParallelExecutableFactory(
 
     protected function createErrorHandler(InputInterface $input, OutputInterface $output): ErrorHandler
     {
-        $errorHandler = new ThrowableCodeErrorHandler(
-            ResetServiceErrorHandler::forContainer($this->getContainer()),
+        return new LoggingErrorHandler(
+            new ThrowableCodeErrorHandler(
+                ResetServiceErrorHandler::forContainer($this->getContainer()),
+            ),
         );
-
-        return new LoggingErrorHandler($errorHandler);
     }
 
     protected function createLogger(InputInterface $input, OutputInterface $output): Logger