Skip to content

Commit 04c454b

Browse files
committed
fail if not admins found for org
also change other lookup errors to 500s
1 parent 3a2828f commit 04c454b

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

backend/btrixcloud/subs.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -202,13 +202,18 @@ async def send_trial_end_reminder(
202202
print(
203203
f"Subscription not found for organization ID {org.id} with sub id {reminder.subId}"
204204
)
205-
raise HTTPException(status_code=404, detail="subscription_not_found")
205+
raise HTTPException(status_code=500, detail="subscription_not_found")
206206

207207
if not org.subscription.futureCancelDate:
208208
print(f"Future cancel date not found for subscription ID {reminder.subId}")
209-
raise HTTPException(status_code=404, detail="future_cancel_date_not_found")
209+
raise HTTPException(status_code=500, detail="future_cancel_date_not_found")
210210

211211
users = await self.org_ops.get_users_for_org(org, UserRole.OWNER)
212+
213+
if len(users) == 0:
214+
print(f"No admin users found for organization ID {org.id}")
215+
raise HTTPException(status_code=500, detail="no_admin_users_found")
216+
212217
await asyncio.gather(
213218
*[
214219
self.user_manager.email.send_subscription_trial_ending_soon(

0 commit comments

Comments
 (0)