QUIZINT-599: Fix errors and warnings for codechecker

Author: xripoll-at-wiris

classes/privacy/provider.php

@@ -39,7 +39,7 @@ class provider implements
     \core_privacy\local\request\plugin\provider {
 
     // This trait must be included to provide the relevant polyfill for the metadata provider.
-    // All required methods must start with an underscore
+    // All required methods must start with an underscore.
     use \core_privacy\local\legacy_polyfill;
 
 

info.php

@@ -115,7 +115,8 @@ function wrs_createtablerow($testname, $reporttext, $solutionlink, $condition) {
 $output .= html_writer::start_tag('tr', array('class' => 'wrs_filter wrs_plugin'));
 
 require_once($CFG->dirroot . '/filter/wiris/version.php');
-$plugininfo = get_string('info_test2_info', 'qtype_wq') . '<a href="../../../filter/wiris/info.php" target="_blank">' . get_string('info_test2_infopage', 'qtype_wq') . '</a>';
+$plugininfo = get_string('info_test2_info', 'qtype_wq') . '<a href="../../../filter/wiris/info.php" target="_blank">' .
+    get_string('info_test2_infopage', 'qtype_wq') . '</a>';
 if (isset($plugin->release)) {
     $version = $plugin->release;
     if ($version >= '3.17.20') {
@@ -513,9 +514,11 @@ function wrs_createtablerow($testname, $reporttext, $solutionlink, $condition) {
         }
     }
     $p->unlockVariable('wiris_maxconnections');
-    echo wrs_createTableRow($testname, sprintf(get_string('info_test12_rt1', 'qtype_wq'), $count, $configmaxconnections, $maxconnections), '', true);
+    echo wrs_createTableRow($testname, sprintf(get_string('info_test12_rt1', 'qtype_wq'),
+        $count, $configmaxconnections, $maxconnections), '', true);
 } catch (Exception $e) {
-    echo wrs_createTableRow($testname, sprintf(get_string('info_test12_rt2', 'qtype_wq'), $e->getMessage(), $e->getTraceAsString()), '', false);
+    echo wrs_createTableRow($testname, sprintf(get_string('info_test12_rt2', 'qtype_wq'),
+        $e->getMessage(), $e->getTraceAsString()), '', false);
 }
 $wrap->stop();
 
@@ -529,7 +532,8 @@ function wrs_createtablerow($testname, $reporttext, $solutionlink, $condition) {
 $output = '';
 $output .= html_writer::start_tag('p', array('class' => 'wrs_filter wrs_plugin'));
 $output .= html_writer::end_tag('br');
-$output .= html_writer::start_tag('span', array('class' => 'wrs_filter wrs_plugin', 'style' => 'font-size:14px; font-weight:normal;'));
+$output .= html_writer::start_tag('span', array('class' => 'wrs_filter wrs_plugin',
+    'style' => 'font-size:14px; font-weight:normal;'));
 $output .= get_string('info_information', 'qtype_wq');
 $output .= " (<a href=\"mailto:support@wiris.com\">support@wiris.com</a>)";
 $output .= html_writer::end_tag('span');

question.php

@@ -221,7 +221,8 @@ public function is_same_response(array $prevresponse, array $newresponse) {
         $baseresponse = $this->base->is_same_response($prevresponse, $newresponse);
         $sqicompare = ((empty($newresponse['_sqi']) && empty($prevresponse['_sqi'])) || (!empty($prevresponse['_sqi']) &&
             !empty($newresponse['_sqi']) && $newresponse['_sqi'] == $prevresponse['_sqi']));
-        $auxiliarcompare = ((empty($newresponse['auxiliar_text']) && empty($prevresponse['auxiliar_text'])) || (!empty($prevresponse['auxiliar_text']) &&
+        $auxiliarcompare = ((empty($newresponse['auxiliar_text']) && empty($prevresponse['auxiliar_text'])) ||
+            (!empty($prevresponse['auxiliar_text']) &&
             !empty($newresponse['auxiliar_text']) && $newresponse['auxiliar_text'] == $prevresponse['auxiliar_text']));
         return $baseresponse && $sqicompare && $auxiliarcompare;
 

renderer.php

@@ -28,9 +28,10 @@ public function __construct(qtype_renderer $base = null, moodle_page $page, $tar
     public function formulation_and_controls(question_attempt $qa, question_display_options $options) {
         $result = $this->base->formulation_and_controls($qa, $options);
 
-        // Auxiliar text
-        $show_auxiliar_text_input = $qa->get_question()->wirisquestion->question->getProperty(com_wiris_quizzes_api_QuizzesConstants::$PROPERTY_SHOW_AUXILIAR_TEXT_INPUT);
-        if ($show_auxiliar_text_input) {
+        // Auxiliar text.
+        $showauxiliartextinput = $qa->get_question()->wirisquestion->question->getProperty(
+            com_wiris_quizzes_api_QuizzesConstants::$PROPERTY_SHOW_AUXILIAR_TEXT_INPUT); // @codingStandardsIgnoreLine
+        if ($showauxiliartextinput) {
             $result .= $this->auxiliar_text($qa, $options);
         }
 
@@ -113,15 +114,15 @@ protected function auxiliar_text(question_attempt $qa, question_display_options
         }
 
         if (empty($options->readonly)) {
-            $auxiliar_text = $responseoutput->response_area_input('auxiliar_text', $qa,
+            $auxiliartext = $responseoutput->response_area_input('auxiliar_text', $qa,
                     $step, $question->auxiliartextfieldlines, $options->context);
 
         } else {
-            $auxiliar_text = $responseoutput->response_area_read_only('auxiliar_text', $qa,
+            $auxiliartext = $responseoutput->response_area_read_only('auxiliar_text', $qa,
                     $step, $question->auxiliartextfieldlines, $options->context);
         }
 
-        $result .= html_writer::tag('div', $auxiliar_text);
+        $result .= html_writer::tag('div', $auxiliartext);
 
         return $result;
     }

settings.php

@@ -71,7 +71,7 @@
                                                             'http://www.wiris.net/demo/wiris',
                                                             PARAM_URL));
 
-// Access provider option. If enabled only loged users can access to Wiris Quizzes services
+// Access provider option. If enabled only loged users can access to Wiris Quizzes services.
 $settings->add(new admin_setting_configcheckbox('qtype_wq/access_provider_enabled',
                                                             get_string('access_provider_enabled', 'qtype_wq'),
                                                             get_string('access_provider_enabled_help', 'qtype_wq'),

tests/behat/behat_wq_base.php

@@ -40,7 +40,7 @@ public function i_open_wiris_quizzes_studio() {
         );
         $this->ensure_node_is_visible($node);
         $node->click();
-        // Mink does not provide any way to call other steps, so we recreate the switch_to_window step from behat_general:
+        // Mink does not provide any way to call other steps, so we recreate the switch_to_window step from behat_general.
         $this->getSession()->executeScript(
                 'if (window.name == "") window.name = "' . behat_general::MAIN_WINDOW_NAME . '"');
         $this->getSession()->switchToWindow('wirisstudiopopup');