Test against target version, not runtime version

Author: thekid

src/main/php/lang/ast/emit/PHP74.class.php

@@ -28,6 +28,8 @@ class PHP74 extends PHP {
     RewriteThrowableExpressions
   ;
 
+  public $targetVersion= 70400;
+
   /** Sets up type => literal mappings */
   public function __construct() {
     $this->literals= [

src/main/php/lang/ast/emit/PHP80.class.php

@@ -31,6 +31,8 @@ class PHP80 extends PHP {
     RewriteStaticVariableInitializations
   ;
 
+  public $targetVersion= 80000;
+
   /** Sets up type => literal mappings */
   public function __construct() {
     $this->literals= [

src/main/php/lang/ast/emit/PHP81.class.php

@@ -28,6 +28,8 @@ class PHP81 extends PHP {
     OmitConstantTypes
   ;
 
+  public $targetVersion= 80100;
+
   /** Sets up type => literal mappings */
   public function __construct() {
     $this->literals= [

src/main/php/lang/ast/emit/PHP82.class.php

@@ -28,6 +28,8 @@ class PHP82 extends PHP {
     OmitConstantTypes
   ;
 
+  public $targetVersion= 80200;
+
   /** Sets up type => literal mappings */
   public function __construct() {
     $this->literals= [

src/main/php/lang/ast/emit/PHP83.class.php

@@ -20,6 +20,8 @@
 class PHP83 extends PHP {
   use RewriteBlockLambdaExpressions, RewriteProperties, ReadonlyClasses;
 
+  public $targetVersion= 80300;
+
   /** Sets up type => literal mappings */
   public function __construct() {
     $this->literals= [

src/main/php/lang/ast/emit/RewriteProperties.class.php

@@ -10,15 +10,17 @@ trait RewriteProperties {
   }
 
   protected function emitProperty($result, $property) {
-    static $asymmetric= null;
     if ($property->hooks) {
       return $this->emitPropertyHooks($result, $property);
     } else if (
-      !($asymmetric ?? $asymmetric= method_exists(ReflectionProperty::class, 'isPrivateSet')) &&
+      $this->targetVersion < 80400 &&
       array_intersect($property->modifiers, ['private(set)', 'protected(set)', 'public(set)'])
     ) {
       return $this->emitAsymmetricVisibility($result, $property);
-    } else if (PHP_VERSION_ID <= 80100 && in_array('readonly', $property->modifiers)) {
+    } else if (
+      $this->targetVersion < 80100 &&
+      in_array('readonly', $property->modifiers)
+    ) {
       return $this->emitReadonlyProperties($result, $property);
     }
     parent::emitProperty($result, $property);