Raise an error when non-array is passed to withProperties

Author: thekid

src/main/php/lang/ast/emit/RewriteCloneWith.class.php

@@ -12,7 +12,7 @@ protected function emitClone($result, $clone) {
     // Wrap clone with, e.g. clone($x, ['id' => 6100]), inside an IIFE which
     /// iterates over the property-value pairs, assigning them to the clone.
     if ($with) {
-      $result->out->write('(function($c, $a) { foreach ($a as $p=>$v) { $c->$p= $v; } return $c;})(clone ');
+      $result->out->write('(function($c, array $a) { foreach ($a as $p=>$v) { $c->$p= $v; } return $c;})(clone ');
       $this->emitOne($result, $expr);
       $result->out->write(',');
       $this->emitOne($result, $with);

src/test/php/lang/ast/unittest/emit/CloningTest.class.php

@@ -1,7 +1,7 @@
 <?php namespace lang\ast\unittest\emit;
 
 use lang\Error;
-use test\{Assert, Before, Ignore, Test, Values};
+use test\{Assert, Before, Expect, Ignore, Test, Values};
 
 /** @see https://www.php.net/manual/en/language.oop5.cloning.php */
 class CloningTest extends EmittingTest {
@@ -124,4 +124,22 @@ public function run() {
       }
     }'));
   }
+
+  #[Test, Expect(Error::class)]
+  public function clone_null_object() {
+    $this->run('class %T {
+      public function run() {
+        return clone(null);
+      }
+    }');
+  }
+
+  #[Test, Expect(Error::class)]
+  public function clone_with_null_properties() {
+    $this->run('class %T {
+      public function run() {
+        return clone($this, null);
+      }
+    }');
+  }
 }