Skip to content

Commit 3fed097

Browse files
Refactor Makefile and remove unnecessary blank lines
- Update Makefile targets to depend on specific source files - Improve echo messages with consistent capitalization - Remove extraneous blank lines in substitution method files - Modify kernel method error handling in SimpleLinearAlgebra module
1 parent 791a2de commit 3fed097

File tree

4 files changed

+7
-9
lines changed

4 files changed

+7
-9
lines changed

Makefile

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,20 @@
11
jl:=julia
22

3-
init:
3+
init: src/SimpleLinearAlgebra.jl
44
$(jl) -e 'd=pwd(); @assert isdir(d);\
55
using Pkg: activate, instantiate, develop, precompile; \
66
activate(d); instantiate(); activate(joinpath(d, "examples")); \
77
develop(path=d); instantiate(); precompile();'
8-
@echo "environment initialized at: $$PWD"
8+
@echo "Environment initialized at: $$PWD"
99

10-
update:
10+
update: src/SimpleLinearAlgebra.jl
1111
$(jl) -e 'd=pwd(); @assert isdir(d);\
1212
using Pkg: activate, update, develop, precompile; \
1313
activate(d); update(); activate(joinpath(d, "examples")); \
1414
update(); precompile();'
15-
@echo "environment updated at: $$PWD"
15+
@echo "Environment updated at: $$PWD"
1616

17-
test:
17+
test: test/runtests.jl
1818
@echo "Running tests at: $$PWD"
1919
$(jl) -e 'd=pwd(); @assert isdir(d);\
2020
using Pkg: activate, test; \

src/SimpleLinearAlgebra.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ module SimpleLinearAlgebra
66
abstract type LinearSystemSolutionMixin end
77

88
function kernel(prob::LinearSystemProblemMixin)
9-
throw(MethodError(kernel, (prob,)))
9+
MethodError(kernel, (typeof(prob),)) |> throw
1010
end
1111

1212
include("forward_substitution.jl")

src/back_substitution.jl

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,5 +37,4 @@ function kernel(prob::BackSubstitutionProblem)
3737
return BackSubstitutionSolution(x)
3838
end
3939

40-
41-
export BackSubstitution, kernel
40+
export BackSubstitution, kernel

src/forward_substitution.jl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,5 +34,4 @@ function kernel(prob::ForwardSubstitutionProblem)
3434
return ForwardSubstitutionSolution(x)
3535
end
3636

37-
3837
export ForwardSubstitution, kernel

0 commit comments

Comments
 (0)