Closing multiple tabs message should exclude unloaded tabs

[Jai-JAP]

When closing a window with multiple tabs open, the alert box reports the open tabs with count including the unloaded tabs +1 (maybe for blank tab??).

This alert box should however not include the count of unloaded tabs / any blank tabs if used

As seen, there is only a single tab opened with 5 others (pinned + essentials) unloaded and the box reports the tab count at 7, with the breakdown as follows 5 unloaded (pinned + essentials) + 1 open + 1 (blank??).

Having the count fixed on the alert box will prevent unwanted confusion.

[dosubot[bot]]

The alert box currently counts all tabs—including unloaded and blank tabs—because it uses a simple tab count without filtering out tabs that are either unloaded or marked as "empty" (with the zen-empty-tab attribute). Other features in the browser, like tab navigation and recent tab lists, already filter out these tabs to avoid confusion, but the close window alert does not yet apply the same logic.

To make the alert more accurate, the code that generates the tab count for the alert should filter out tabs with the zen-empty-tab attribute (which are blank tabs) and, if needed, tabs that are unloaded (often marked with the pending attribute or similar). This would bring the alert in line with how other tab-related features count tabs and prevent confusion about the number of "real" open tabs.

You can see examples of this filtering logic in other parts of the codebase, such as navigation and tab lists, where tabs with zen-empty-tab and sometimes pending are excluded from counts and actions (source).

Updating the alert logic to use a filtered tab list will resolve the issue you described.

To reply, just mention @dosu.

---

^{How did I do? Good | Irrelevant | Incorrect | Verbose | Hallucination | Report 🐛 | Other}   

[Jai-JAP]

After updating to the latest 1.14.0b, this issue has changed as it counts the total non pinned tabs instead of counting all excluding the unloaded ones.

This results in the tab count still being incorrect but also when closing with only one normal tab open & multiple other pinned / essentials, the browser just closes without any warning, leading to lost work.

[Jai-JAP]

This issue is still the same in 1.14.4b

you can see that the number of open tabs is 7 but the close dialog shows as 5 which excludes the pinned & essential tabs. This is an issue ignoring the other opened tabs instead of just ignoring the unloaded ones.

@mr-cheffy Sorry for the ping but please look into this.

[Jai-JAP]

Found the culprit

https://github.com/mozilla-firefox/firefox/blob/c70baa93114a68a3ae3adca7e437204c72015768/browser/components/BrowserGlue.sys.mjs#L1493

Should be replaced by

        pagecount += tabbrowser.visibleTabs.filter(t => t.getAttribute("pending")!=true).length;