Apply suggestions from code review

drewnoakes · web-flow · commit 9fe9ea7070ac · 2025-06-13T22:49:50.000+10:00
diff --git a/src/NetMQ.Tests/NetMQPollerTest.cs b/src/NetMQ.Tests/NetMQPollerTest.cs
@@ -53,7 +53,7 @@ public void ResponsePoll()
         }
 
         [Fact(Timeout=5000)]
-        public async void Monitoring()
+        public async Task Monitoring()
         {
             var listeningEvent = new ManualResetEvent(false);
             var acceptedEvent = new ManualResetEvent(false);
@@ -83,7 +83,7 @@ public async void Monitoring()
 
                 // keep the test from blocking when something goes wrong.
                 var timeout = new CancellationTokenSource(5000).Token;
-                Exception e = null;
+                Exception? e = null;
 
                 await Task.Run(() =>
                 {

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ public void ResponsePoll()`
`53`	`53`	`}`
`54`	`54`
`55`	`55`	`[Fact(Timeout=5000)]`
`56`		`- public async void Monitoring()`
	`56`	`+ public async Task Monitoring()`
`57`	`57`	`{`
`58`	`58`	`var listeningEvent = new ManualResetEvent(false);`
`59`	`59`	`var acceptedEvent = new ManualResetEvent(false);`
`@@ -83,7 +83,7 @@ public async void Monitoring()`
`83`	`83`
`84`	`84`	`// keep the test from blocking when something goes wrong.`
`85`	`85`	`var timeout = new CancellationTokenSource(5000).Token;`
`86`		`- Exception e = null;`
	`86`	`+ Exception? e = null;`
`87`	`87`
`88`	`88`	`await Task.Run(() =>`
`89`	`89`	`{`