Skip to content

Commit 2a00552

Browse files
committed
Address PR Comment - Remove quotes ` from secret: True and add . in the error message
1 parent f7b4636 commit 2a00552

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

st2common/st2common/util/pack.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -107,10 +107,10 @@ def validate_config_against_schema(config_schema, config_object, config_path,
107107
for key in config_object:
108108
if (jinja_utils.is_jinja_expression(value=config_object.get(key)) and
109109
"decrypt_kv" in config_object.get(key) and config_schema.get(key).get('secret')):
110-
raise ValueValidationException('Values specified as `secret: True` in config schema '
110+
raise ValueValidationException('Values specified as secret: True in config schema '
111111
'are automatically decrypted by default. Use of '
112-
'`decrypt_kv` jinja filter is not allowed for such '
113-
'values')
112+
'decrypt_kv jinja filter is not allowed for such '
113+
'values.')
114114

115115
schema = util_schema.get_schema_for_resource_parameters(parameters_schema=config_schema,
116116
allow_additional_properties=True)

st2common/tests/unit/test_configs_registrar.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -168,10 +168,10 @@ def test_register_all_configs_with_config_schema_validation_validation_failure_3
168168
registrar._register_pack(pack_name='dummy_pack_11', pack_dir=PACK_11_PATH)
169169
packs_base_paths = content_utils.get_packs_base_paths()
170170

171-
expected_msg = ('Values specified as `secret: True` in config schema '
171+
expected_msg = ('Values specified as secret: True in config schema '
172172
'are automatically decrypted by default. Use of '
173-
'`decrypt_kv` jinja filter is not allowed for such '
174-
'values')
173+
'decrypt_kv jinja filter is not allowed for such '
174+
'values.')
175175

176176
self.assertRaisesRegexp(ValueError, expected_msg,
177177
registrar.register_from_packs,

0 commit comments

Comments
 (0)