test

Author: jfdoming

packages/loot-core/src/platform/server/fs/index.web.ts

@@ -258,7 +258,6 @@ export const populateFileHeirarchy = async function () {
 
 export const init = async function () {
   const Module = _getModule();
-  // @ts-expect-error - incorrect types
   FS = Module.FS;
 
   // When a user "uploads" a file, we just put it in memory in this
@@ -284,7 +283,6 @@ export const init = async function () {
       connection.send('fallback-write-error');
     });
     BFS = new SQLiteFS(FS, backend);
-    // @ts-expect-error - incorrect types
     Module.register_for_idb(BFS);
 
     FS.mount(BFS, {}, '/blocked');

packages/loot-core/src/platform/server/sqlite/index.d.ts

@@ -1,6 +1,6 @@
-import type { SqlJsStatic, Database } from '@jlongster/sql.js';
+import { type Database } from '@jlongster/sql.js';
 
-export function init(): Promise<void>;
+export async function init(): Promise<void>;
 
 export function _getModule(): SqlJsStatic;
 
@@ -23,13 +23,13 @@ export function execQuery(db: Database, sql): void;
 
 export function transaction(db: Database, fn: () => void): void;
 
-export function asyncTransaction(
+export async function asyncTransaction(
   db: Database,
   fn: () => Promise<void>,
 ): Promise<void>;
 
-export function openDatabase(pathOrBuffer?: string | Buffer): Promise<Database>;
+export async function openDatabase(pathOrBuffer?: string | Buffer): Database;
 
 export function closeDatabase(db: Database): void;
 
-export function exportDatabase(db: Database): Promise<Uint8Array>;
+export async function exportDatabase(db: Database): Promise<Uint8Array>;

packages/loot-core/src/platform/server/sqlite/index.electron.ts

@@ -102,7 +102,7 @@ function regexp(regex: string, text: string | null) {
   return new RegExp(regex).test(text || '') ? 1 : 0;
 }
 
-export async function openDatabase(pathOrBuffer: string | Buffer) {
+export function openDatabase(pathOrBuffer: string | Buffer) {
   const db = new SQL(pathOrBuffer);
   // Define Unicode-aware LOWER, UPPER, and LIKE implementation.
   // This is necessary because better-sqlite3 uses SQLite build without ICU support.

packages/loot-core/src/server/accounts/transactions.ts

@@ -184,6 +184,5 @@ export async function batchUpdateTransactions({
   return {
     added: resultAdded,
     updated: runTransfers ? transfersUpdated : resultUpdated,
-    deleted: allDeleted,
   };
 }

packages/loot-core/src/server/backups.ts

@@ -122,7 +122,7 @@ export async function makeBackup(id: string) {
   await fs.copyFile(fs.join(budgetDir, 'db.sqlite'), backupPath);
 
   // Remove all the messages from the backup
-  const db = await sqlite.openDatabase(backupPath);
+  const db = sqlite.openDatabase(backupPath);
   await sqlite.runQuery(db, 'DELETE FROM messages_crdt');
   await sqlite.runQuery(db, 'DELETE FROM messages_clock');
   sqlite.closeDatabase(db);

packages/loot-core/src/server/main.ts

@@ -553,7 +553,7 @@ handlers['create-query'] = async function ({ sheetName, name, query }) {
 };
 
 handlers['query'] = async function (query) {
-  if (query['table'] == null) {
+  if (query.table == null) {
     throw new Error('query has no table, did you forgot to call `.serialize`?');
   }
 

packages/loot-core/src/server/mutators.ts

@@ -1,21 +1,22 @@
+// @ts-strict-ignore
 import { captureException, captureBreadcrumb } from '../platform/exceptions';
 import { sequential } from '../shared/async';
 import { type HandlerFunctions, type Handlers } from '../types/handlers';
 
 const runningMethods = new Set();
 
-let currentContext: Record<string, unknown> | null = null;
+let currentContext = null;
 const mutatingMethods = new WeakMap();
 let globalMutationsEnabled = false;
 
-let _latestHandlerNames: (string | undefined)[] = [];
+let _latestHandlerNames = [];
 
 export function mutator<T extends HandlerFunctions>(handler: T): T {
   mutatingMethods.set(handler, true);
   return handler;
 }
 
-export function isMutating<T extends HandlerFunctions>(handler: T) {
+export function isMutating(handler) {
   return mutatingMethods.has(handler);
 }
 
@@ -33,14 +34,14 @@ async function flushRunningMethods() {
   }
 }
 
-function wait(time: number) {
+function wait(time) {
   return new Promise(resolve => setTimeout(resolve, time));
 }
 
 export async function runHandler<T extends Handlers[keyof Handlers]>(
   handler: T,
   args?: Parameters<T>[0],
-  { undoTag, name }: { undoTag?: string; name?: string } = {},
+  { undoTag, name }: { undoTag?; name? } = {},
 ): Promise<ReturnType<T>> {
   // For debug reasons, track the latest handlers that have been
   // called

packages/loot-core/src/types/server-handlers.d.ts

@@ -4,7 +4,7 @@ import { Backup } from '../server/backups';
 import { RemoteFile } from '../server/cloud-storage';
 import { Node as SpreadsheetNode } from '../server/spreadsheet/spreadsheet';
 import { Message } from '../server/sync';
-import { Query, QueryState } from '../shared/query';
+import { QueryState } from '../shared/query';
 
 import { Budget } from './budget';
 import {
@@ -19,6 +19,8 @@ import {
 } from './models';
 import { OpenIdConfig } from './models/openid';
 import { GlobalPrefs, MetadataPrefs } from './prefs';
+// eslint-disable-next-line import/no-unresolved
+import { Query } from './query';
 import { EmptyObject } from './util';
 
 export interface ServerHandlers {
@@ -137,9 +139,7 @@ export interface ServerHandlers {
 
   'create-query': (arg: { sheetName; name; query }) => Promise<unknown>;
 
-  query: (
-    query: Query | QueryState,
-  ) => Promise<{ data: unknown; dependencies }>;
+  query: (query: Query) => Promise<{ data: unknown; dependencies }>;
 
   'account-update': (arg: { id; name }) => Promise<unknown>;
 

packages/loot-core/src/types/util.d.ts

@@ -4,11 +4,9 @@ export type StripNever<T> = {
   [K in keyof T as T[K] extends never ? never : K]: T[K];
 };
 
-export type EverythingButIdOptional<
-  T extends {
-    id: unknown;
-  },
-> = { id: T['id'] } & Partial<Omit<T, 'id'>>;
+export type EverythingButIdOptional<T> = { id: T['id'] } & Partial<
+  Omit<T, 'id'>
+>;
 
 export type WithRequired<T, K extends keyof T> = T & Required<Pick<T, K>>;