point package.json types property to including type declarations #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #58 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 30 30
Branches 8 8
=========================================
Hits 30 30 Continue to review full report at Codecov.
|
kentcdodds
approved these changes
Jun 24, 2020
|
🎉 This PR is included in version 2.2.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
I do get an eslint error
FallbackProps not found in 'react-error-boundary' import/namedwitheslint-import-resolver-typescriptas it seems that the built js bundles gets favored over the included types.Why:
I'm aware that the problem might be related to how
eslint-import-resolver-typescriptis trying to resolve the types, but adding the thetypesprop in package.json fixes the issue and is advised by the typescript team anyways.How:
point the
typesprop in package.json to the declaration file.Checklist: