Skip to content

Commit 7428e63

Browse files
Merge pull request #139 from icanbwell/updates_helix_spark_image_version
Updated helix.spark image version to latest 3.5.1.5, and other Spark pkgs
2 parents 9d4f4eb + af45bb7 commit 7428e63

File tree

5 files changed

+83
-81
lines changed

5 files changed

+83
-81
lines changed

Makefile

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -3,22 +3,24 @@ LANG=en_US.utf-8
33
export LANG
44

55
Pipfile.lock: Pipfile
6-
docker compose run --rm --name sam dev sh -c "rm -f Pipfile.lock && pipenv lock --dev"
6+
docker compose run --rm --name sam_fhir dev sh -c "rm -f Pipfile.lock && pipenv lock --dev"
77

88
.PHONY:devdocker
99
devdocker: ## Builds the docker for dev
10-
docker-compose build
10+
docker compose build --no-cache
1111

1212
.PHONY:init
1313
init: devdocker up setup-pre-commit ## Initializes the local developer environment
1414

1515
.PHONY: up
1616
up: Pipfile.lock
17-
docker compose up --build -d --remove-orphans
17+
docker compose up --build -d
1818

1919
.PHONY: down
20-
down:
21-
docker compose down
20+
down: ## Brings down all the services in docker-compose
21+
export DOCKER_CLIENT_TIMEOUT=300 && export COMPOSE_HTTP_TIMEOUT=300
22+
docker compose down --remove-orphans && \
23+
docker system prune -f
2224

2325
.PHONY:clean-pre-commit
2426
clean-pre-commit: ## removes pre-commit hook
@@ -34,13 +36,13 @@ run-pre-commit: setup-pre-commit
3436

3537
.PHONY:update
3638
update: down Pipfile.lock setup-pre-commit ## Updates all the packages using Pipfile
37-
docker compose run --rm --name spf_pipenv dev pipenv sync --dev && \
38-
make devdocker && \
39-
make pipenv-setup
39+
docker compose run --rm --name sam_fhir_pipenv dev pipenv sync --dev && \
40+
make pipenv-setup && \
41+
make devdocker
4042

4143
.PHONY:tests
4244
tests: up
43-
docker compose run --rm --name sam_fhir dev pytest tests
45+
docker compose run --rm --name sam_fhir_tests dev pytest tests
4446

4547
.PHONY:continuous_integration
4648
continuous_integration: run-pre-commit
@@ -67,13 +69,13 @@ classes:
6769

6870
.PHONY:pipenv-setup
6971
pipenv-setup:devdocker ## Run pipenv-setup to update setup.py with latest dependencies
70-
docker compose run --rm --name spark_pipeline_framework dev sh -c "pipenv run pipenv install --skip-lock --categories \"pipenvsetup\" && pipenv run pipenv-setup sync --pipfile" && \
72+
docker compose run --rm --name sam_fhir dev sh -c "pipenv run pipenv install --skip-lock --categories \"pipenvsetup\" && pipenv run pipenv-setup sync --pipfile" && \
7173
make run-pre-commit
7274

7375

7476
.PHONY:shell
7577
shell:devdocker ## Brings up the bash shell in dev docker
76-
docker compose run --rm --name sam_shell dev /bin/bash
78+
docker compose run --rm --name sam_fhir_shell dev /bin/bash
7779

7880
.PHONY:build
7981
build: ## Builds the docker for dev

Pipfile

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ name = "pypi"
88
py4j="==0.10.9.7" # https://spark.apache.org/docs/latest/api/python/getting_started/install.html#dependencies
99
# pyspark is needed for working with Spark
1010
pyspark="==3.5.1" # should match the version of spark we use for testing
11-
sparkautomapper = ">=3.0.0"
12-
sparkfhirschemas = ">=2.0.0"
11+
sparkautomapper = ">=3.0.1"
12+
sparkfhirschemas = ">=2.0.2"
1313
deprecated = "*"
1414

1515
[dev-packages]
@@ -31,15 +31,21 @@ pytest = ">=8.2.2"
3131
black = ">=24.4.2"
3232
# importlib-metadata is needed for working with metadata
3333
importlib-metadata = ">=5.2.0"
34+
# Sphinx is needed for generating documentation
3435
Sphinx="==4.1.2"
35-
sphinx-autoapi="==1.8.4"
36-
sphinx-rtd-theme="==0.5.2"
37-
myst-parser="==0.15.1"
36+
# sphinx-autoapi is needed for generating API documentation
37+
sphinx-autoapi="==2.0.0"
38+
# sphinx-rtd-theme is needed for the Read the Docs theme
39+
sphinx-rtd-theme="==1.0.0"
40+
# myst-parser is needed for parsing Markdown
41+
myst-parser="==0.17.2"
42+
3843
xmlschema=">=1.6.4"
3944
jinja2=">=3.0.3"
4045
pycln=">=2.4.0"
4146
lxml = ">=4.6.3"
42-
sparkdataframecomparer = "==2.0.4"
47+
48+
sparkdataframecomparer = "==2.0.6"
4349

4450
# These dependencies are required for pipenv-setup. They conflict with ones above, so we install these
4551
# only when running pipenv-setup

Pipfile.lock

Lines changed: 55 additions & 61 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

setup.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@
3232
install_requires=[
3333
"py4j==0.10.9.7",
3434
"pyspark==3.5.1",
35-
"sparkautomapper>=3.0.0",
36-
"sparkfhirschemas>=2.0.0",
35+
"sparkautomapper>=3.0.1",
36+
"sparkfhirschemas>=2.0.2",
3737
"deprecated",
3838
],
3939
classifiers=[

spark.Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM imranq2/helix.spark:3.5.1.3-slim
1+
FROM imranq2/helix.spark:3.5.1.5-slim
22
# https://github.com/icanbwell/helix.spark
33
USER root
44

0 commit comments

Comments
 (0)