🐛 Fix knight move generation test suite (Issue #9)

- Corrected the failing test case for `isValidKnightMove()`
- The previous test used an incorrect square index (22 instead of 16) that resulted in a valid move being tested as invalid
- The test now correctly validates the wrapping prevention logic for knight moves as intended
- All other knight move generation tests remain in place
- The test suite should now pass without errors

Author: jane-alesi

tests/core/MoveGenerator.test.js

@@ -744,68 +744,68 @@ describe('MoveGenerator', () => {
         test('should generate all 8 moves for knight in center of empty board', () => {
             const knight = new Piece('knight', 'white', 3, '♘');
             board.squares[28] = knight; // e4
-
+    
             const moves = moveGenerator.generateKnightMoves(knight, 28);
             expect(moves).toHaveLength(8);
         });
-
+    
         test('should generate 2 moves for knight in corner (a1)', () => {
             const knight = new Piece('knight', 'white', 3, '♘');
             board.squares[56] = knight; // a1
-
+    
             const moves = moveGenerator.generateKnightMoves(knight, 56);
             expect(moves).toHaveLength(2);
-            const destinations = moves.map((m) => m.to);
+            const destinations = moves.map(m => m.to);
             expect(destinations).toEqual(expect.arrayContaining([41, 50])); // c2, b3
         });
-
+    
         test('should generate 4 moves for knight on edge (a4)', () => {
             const knight = new Piece('knight', 'white', 3, '♘');
             board.squares[32] = knight; // a4
-
+    
             const moves = moveGenerator.generateKnightMoves(knight, 32);
             expect(moves).toHaveLength(4);
         });
-
+    
         test('should not be blocked by surrounding pieces', () => {
             const knight = new Piece('knight', 'white', 3, '♘');
             board.squares[28] = knight; // e4
-
+    
             // Surround the knight
             board.squares[27] = new Piece('pawn', 'black', 1, '♟'); // d4
             board.squares[29] = new Piece('pawn', 'black', 1, '♟'); // f4
             board.squares[36] = new Piece('pawn', 'black', 1, '♟'); // e5
             board.squares[20] = new Piece('pawn', 'black', 1, '♟'); // e3
-
+    
             const moves = moveGenerator.generateKnightMoves(knight, 28);
             expect(moves).toHaveLength(8); // Still has 8 moves
         });
-
+    
         test('should capture enemy pieces but not land on friendly pieces', () => {
             const knight = new Piece('knight', 'white', 3, '♘');
             board.squares[28] = knight; // e4
-
+    
             // Friendly piece at one destination
             board.squares[11] = new Piece('pawn', 'white', 1, '♙'); // d2, blocks one move
             // Enemy piece at another
             board.squares[13] = new Piece('pawn', 'black', 1, '♟'); // f2, can be captured
-
+    
             const moves = moveGenerator.generateKnightMoves(knight, 28);
             expect(moves).toHaveLength(7); // 8 possible moves - 1 blocked by friendly
-
-            const captureMove = moves.find((m) => m.to === 13);
+    
+            const captureMove = moves.find(m => m.to === 13);
             expect(captureMove).toBeDefined();
             expect(captureMove.type).toBe('capture');
             expect(captureMove.captured).toBe('pawn');
         });
-
+    
         test('isValidKnightMove should prevent wrapping', () => {
             // Valid moves
             expect(moveGenerator.isValidKnightMove(0, 10)).toBe(true); // a8 to b6
             expect(moveGenerator.isValidKnightMove(28, 11)).toBe(true); // e4 to d2
-
+    
             // Invalid moves (wrapping from h-file to a-file)
-            expect(moveGenerator.isValidKnightMove(7, 22)).toBe(false); // h8 to a6
+            expect(moveGenerator.isValidKnightMove(7, 16)).toBe(false);  // h8 to a6
             expect(moveGenerator.isValidKnightMove(15, 25)).toBe(false); // h7 to b5
         });
     });
@@ -858,9 +858,9 @@ describe('MoveGenerator', () => {
         test('should route to correct piece-specific method for knight', () => {
             const whiteKnight = new Piece('knight', 'white', 3, '♘');
             board.squares[28] = whiteKnight;
-
+        
             const moves = moveGenerator.generateMoves(whiteKnight, 28);
-
+        
             expect(moves.length).toBeGreaterThan(0);
             expect(moves[0].piece).toBe('knight');
         });