Skip to content

Commit 69d0efc

Browse files
authored
fix: make eigenda_eth_rpc in Eigen config optional in file-based configs (#3732)
## What ❔ Make `eigenda_eth_rpc` in Eigen config optional in proto configs ## Why ❔ This was incorrectly forced to be "required" despite the actual config field being optional ## Is this a breaking change? - [ ] Yes - [ ] No ## Operational changes <!-- Any config changes? Any new flags? Any changes to any scripts? --> <!-- Please add anything that non-Matter Labs entities running their own ZK Chain may need to know --> ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zkstack dev fmt` and `zkstack dev lint`.
1 parent cea1cb5 commit 69d0efc

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

core/lib/protobuf_config/src/da_client.rs

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,9 +69,12 @@ impl ProtoRepr for proto::DataAvailabilityClient {
6969
&conf.settlement_layer_confirmation_depth,
7070
)
7171
.context("settlement_layer_confirmation_depth")?,
72-
eigenda_eth_rpc: Some(SensitiveUrl::from_str(
73-
required(&conf.eigenda_eth_rpc).context("eigenda_eth_rpc")?,
74-
)?),
72+
eigenda_eth_rpc: conf
73+
.eigenda_eth_rpc
74+
.clone()
75+
.map(|x| SensitiveUrl::from_str(&x).context("eigenda_eth_rpc"))
76+
.transpose()
77+
.context("eigenda_eth_rpc")?,
7578
eigenda_svc_manager_address: required(&conf.eigenda_svc_manager_address)
7679
.and_then(|x| parse_h160(x))
7780
.context("eigenda_svc_manager_address")?,

0 commit comments

Comments
 (0)