Skip to content

Add a new review mode between object and document review, that is used for reviewing an objects text content #18539

@Emil-18

Description

@Emil-18

Is your feature request related to a problem? Please describe.

  • In focus mode on the web, you can't review the name/value of objects that uses the IA2 textInfo. Same goes for any object that doesn't use the NVDAObjectTextInfo.
  • Braille isn't guarantied to show the text content of the review position when tethered to review and review isn't an instance of NVDAObjectTextInfo
  • You can't decide to move the mouse to the center of the navigator object, or perform the navigator objects default action, if its textInfo implements pointAtStart and activate, respectivly.

Describe the solution you'd like

Add a new review mode between object and document, maybee called text review, that:

  • Swiches on and off automaticly, like document review does. I think this should be switched on automaticly in any situation where the objects textInfo doesn't inherit from NVDAObjectTextInfo
  • Shows the text of the objects actual textInfo, as long as it doesn't inherit from NVDAObjectTextInfo
  • If the objects textInfo Inherit from NVDAObjectTextInfo, look for another textInfo property, maybe called textReviewTextInfo, and not switch automaticly, I think this can be handy for the IA2 textInfo, so the user can choose if they want to review the visual text of the object, but reviews the name/value by default.
  • If this new property isn't implemented, and the objects textInfo inherit from NVDAObjectTextInfo, text review shouldn't be available.

I think object review should then be available anywhere, and let the user review the content of the NVDAObjectTextInfo, or the navigator objects textInfo if it inherits from NVDAObjectTextInfo, no matter what, even in textFields. I think braille.NVDAObjectHasUsefulText only should decide for focus. for the navigator object, I think braille should always show the contents of the review position, except when the review mode is set to object. If the review mode is set to object, it should never show the contents of the review position.

Describe alternatives you've considered

Additional context

I don't know if this would be considered API breaking or not

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions