bugfix(args): normalize empty credentials (#198)

* bugfix(args): normalize empty credentials

* test(args): add test for bugfix

* bugfix(args): also check for empty session_token and security_token

---------

Co-authored-by: mdolinin <mike.dolinin@offerup.com>

Author: uriofferup

awscurl/awscurl.py

@@ -433,6 +433,17 @@ def load_aws_config(access_key, secret_key, security_token, credentials_path, pr
     return access_key, secret_key, security_token
 
 
+def normalize_args(args):
+    if args.access_key == "":
+        args.access_key = None
+    if args.secret_key == "":
+        args.secret_key = None
+    if args.security_token == "":
+        args.security_token = None
+    if args.session_token == "":
+        args.session_token = None
+
+
 def inner_main(argv):
     """
     Awscurl CLI main entry point
@@ -479,6 +490,7 @@ def inner_main(argv):
     parser.add_argument('uri')
 
     args = parser.parse_args(argv)
+    normalize_args(args)
     # pylint: disable=global-statement
     global IS_VERBOSE
     IS_VERBOSE = args.verbose

tests/integration_test.py

@@ -125,3 +125,13 @@ def test_exit_code(self, *args, **kwargs):
             inner_main(['--verbose', '--service', 's3', 'https://awscurl-sample-bucket.s3.amazonaws.com']),
             1
         )
+
+class TestInnerMainMethodEmptyCredentials(TestCase):
+    maxDiff = None
+
+    def test_exit_code(self, *args, **kwargs):
+        self.assertEqual(
+            inner_main(['--verbose', '--access_key', '', '--secret_key', '', '--session_token', '', '--service', 's3',
+                        'https://awscurl-sample-bucket.s3.amazonaws.com']),
+            1
+        )