Skip to content

Commit 030f25f

Browse files
majetideepakaditi-pandit
authored andcommitted
[native] Remove sanity check for event base from idle session in GCC
We need this to avoid SIGSEGV when exchange.http-client.enable-connection-pool=true
1 parent 8af5d11 commit 030f25f

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

presto-native-execution/presto_cpp/main/http/HttpClient.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -462,10 +462,14 @@ folly::SemiFuture<proxygen::HTTPTransaction*> HttpClient::createTransaction(
462462
}
463463
VLOG(3) << "Reuse idle connection from different thread to "
464464
<< address_.describe();
465+
// Skip this check for GCC to prevent SIGSEGV as described in the issue:
466+
// https://github.com/prestodb/presto/issues/22995
467+
#if defined(__clang__)
465468
auto* evb = session->getEventBase();
466469
// The event base from idle session should not be the current event base,
467470
// otherwise we should have already got it from the local session pool.
468471
VELOX_CHECK(!evb || !evb->isInEventBaseThread());
472+
#endif
469473
session->attachThreadLocals(
470474
eventBase_,
471475
sslContext_,

0 commit comments

Comments
 (0)