Fix interpreting like expressions with escape

#23456 incorrectly changed the
invokation of the like function to use the unescaped pattern for a call
that expects the pattern to still contain the escape characters. As a
result, any escaped characters were treated as though they were not
escaped.  This affects certain queries when all arguments to the like
predicate are constants.

Author: rschlussel

presto-main/src/main/java/com/facebook/presto/sql/planner/RowExpressionInterpreter.java

@@ -148,6 +148,7 @@ public RowExpressionInterpreter(RowExpression expression, Metadata metadata, Con
     {
         this(expression, metadata.getFunctionAndTypeManager(), session, optimizationLevel);
     }
+
     public RowExpressionInterpreter(RowExpression expression, FunctionAndTypeManager functionAndTypeManager, ConnectorSession session, Level optimizationLevel)
     {
         this.expression = requireNonNull(expression, "expression is null");
@@ -922,8 +923,7 @@ private SpecialCallResult tryHandleLike(CallExpression callExpression, List<Obje
                 // this corresponds to ExpressionInterpreter::getConstantPattern
                 if (hasEscape) {
                     // like_pattern(pattern, escape)
-                    Slice unescapedPattern = unescapeLiteralLikePattern((Slice) nonCompiledPattern, (Slice) escape);
-                    possibleCompiledPattern = functionInvoker.invoke(((CallExpression) possibleCompiledPattern).getFunctionHandle(), session.getSqlFunctionProperties(), unescapedPattern, escape);
+                    possibleCompiledPattern = functionInvoker.invoke(((CallExpression) possibleCompiledPattern).getFunctionHandle(), session.getSqlFunctionProperties(), nonCompiledPattern, escape);
                 }
                 else {
                     // like_pattern(pattern)

presto-tests/src/main/java/com/facebook/presto/tests/TestLikeQueries.java

@@ -23,7 +23,8 @@ public class TestLikeQueries
         extends AbstractTestQueryFramework
 {
     @Override
-    protected QueryRunner createQueryRunner() throws Exception
+    protected QueryRunner createQueryRunner()
+            throws Exception
     {
         Session session = testSessionBuilder()
                 .setCatalog("test")
@@ -35,8 +36,13 @@ protected QueryRunner createQueryRunner() throws Exception
     @Test
     public void testLikeQueriesWithEscape()
     {
-        assertQuerySucceeds("SELECT IF('_T' LIKE '#_T' ESCAPE '#', c0, c1) FROM (values (true, false)) t(c0, c1)");
-        assertQuerySucceeds("SELECT IF(c2 LIKE 'T' ESCAPE '#', c0, c1) FROM (values (true, false, 'T')) t(c0, c1, c2)");
+        assertQuery("SELECT IF('xT' LIKE '#_T' ESCAPE '#', c0, c1) FROM (values (true, false)) t(c0, c1)", "SELECT false");
+        assertQuery("SELECT IF(c2 LIKE 'T' ESCAPE '#', c0, c1) FROM (values (true, false, 'T')) t(c0, c1, c2)", "SELECT true");
+    }
+
+    @Test
+    public void testLikeQueriesWithInvalidEscape()
+    {
         assertQueryFails("SELECT IF('T' LIKE '###T' ESCAPE '##', c0, c1) FROM (values (true, false)) t(c0, c1)", ".*Escape string must be a single character$");
         assertQueryFails("SELECT IF(c2 LIKE '' ESCAPE '', c0, c1) FROM (values (true, false, 'T')) t(c0, c1, c2)", ".*Escape string must be a single character$");
     }