Skip to content

Commit 8cceea2

Browse files
committed
[native] Include glog for thrift artifact build
An upgrade to folly introduces the glog headers into the build of thrift artifacts. This commit adds the glog include directory when building the targets.
1 parent f73097f commit 8cceea2

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

presto-native-execution/presto_cpp/main/thrift/CMakeLists.txt

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,13 @@ thrift_library(
3232
target_link_libraries(presto_thrift-cpp2 ${THRIFT_PROTOCOL} ${THRIFT_METADATA}
3333
${THRIFT_CORE} ${THRIFT_TRANSPORT})
3434
set(presto_thrift_INCLUDES ${CMAKE_CURRENT_BINARY_DIR})
35-
target_include_directories(presto_thrift-cpp2 PUBLIC ${presto_thrift_INCLUDES})
36-
target_include_directories(presto_thrift-cpp2-obj PUBLIC ${THRIFT_INCLUDES})
35+
target_include_directories(presto_thrift-cpp2 PUBLIC ${presto_thrift_INCLUDES}
36+
${GLOG_INCLUDE_DIR})
37+
target_include_directories(presto_thrift-cpp2-obj PUBLIC ${THRIFT_INCLUDES}
38+
${GLOG_INCLUDE_DIR})
3739

3840
add_library(presto_thrift_extra ProtocolToThrift.cpp)
39-
target_include_directories(presto_thrift_extra PUBLIC ${presto_thrift_INCLUDES}
40-
${THRIFT_INCLUDES})
41-
target_include_directories(presto_thrift_extra PUBLIC ${presto_thrift_INCLUDES})
41+
target_include_directories(
42+
presto_thrift_extra PUBLIC ${presto_thrift_INCLUDES} ${THRIFT_INCLUDES}
43+
${GLOG_INCLUDE_DIR})
4244
add_dependencies(presto_thrift_extra presto_thrift-cpp2)

0 commit comments

Comments
 (0)