Skip to content

Commit 9bddf1c

Browse files
authored
Deferring 8 GPU test (#6102)
1 parent 24c13ca commit 9bddf1c

File tree

2 files changed

+28
-21
lines changed

2 files changed

+28
-21
lines changed

.github/workflows/pr-test.yml

Lines changed: 27 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,14 @@ on:
77
- "python/**"
88
- "scripts/**"
99
- "test/**"
10+
- ".github/workflows/pr-test.yml"
1011
pull_request:
1112
branches: [ main ]
1213
paths:
1314
- "python/**"
1415
- "scripts/**"
1516
- "test/**"
17+
- ".github/workflows/pr-test.yml"
1618
workflow_dispatch:
1719
inputs:
1820
version:
@@ -87,24 +89,6 @@ jobs:
8789
cd test/srt
8890
python3 run_suite.py --suite per-commit-2-gpu
8991
90-
unit-test-backend-8-gpu:
91-
if: (github.repository == 'sgl-project/sglang' || github.event_name == 'pull_request') &&
92-
github.event.pull_request.draft == false
93-
runs-on: 8-gpu-runner
94-
steps:
95-
- name: Checkout code
96-
uses: actions/checkout@v4
97-
98-
- name: Install dependencies
99-
run: |
100-
bash scripts/ci_install_dependency_8_gpu.sh
101-
102-
- name: Run test
103-
timeout-minutes: 20
104-
run: |
105-
cd test/srt
106-
python3 run_suite.py --suite per-commit-8-gpu
107-
10892
performance-test-1-gpu-part-1:
10993
if: (github.repository == 'sgl-project/sglang' || github.event_name == 'pull_request') &&
11094
github.event.pull_request.draft == false
@@ -256,12 +240,35 @@ jobs:
256240
cd test/srt
257241
python3 test_moe_eval_accuracy_large.py
258242
243+
large-scale-test-8-gpu:
244+
if: (github.repository == 'sgl-project/sglang' || github.event_name == 'pull_request') &&
245+
github.event.pull_request.draft == false
246+
needs: [
247+
unit-test-frontend, unit-test-backend-1-gpu, unit-test-backend-2-gpu,
248+
performance-test-1-gpu-part-1, performance-test-1-gpu-part-2, performance-test-2-gpu,
249+
accuracy-test-1-gpu, accuracy-test-2-gpu,
250+
]
251+
runs-on: 8-gpu-runner
252+
steps:
253+
- name: Checkout code
254+
uses: actions/checkout@v4
255+
256+
- name: Install dependencies
257+
run: |
258+
bash scripts/ci_install_dependency_8_gpu.sh
259+
260+
- name: Run test
261+
timeout-minutes: 25
262+
run: |
263+
cd test/srt
264+
python3 run_suite.py --suite per-commit-8-gpu
265+
259266
finish:
260267
if: always()
261268
needs: [
262-
unit-test-frontend, unit-test-backend-1-gpu, unit-test-backend-2-gpu, unit-test-backend-8-gpu,
269+
unit-test-frontend, unit-test-backend-1-gpu, unit-test-backend-2-gpu,
263270
performance-test-1-gpu-part-1, performance-test-1-gpu-part-2, performance-test-2-gpu,
264-
accuracy-test-1-gpu, accuracy-test-2-gpu,
271+
accuracy-test-1-gpu, accuracy-test-2-gpu, large-scale-test-8-gpu,
265272
]
266273
runs-on: ubuntu-latest
267274
steps:

test/srt/test_pp_single_node.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ def test_gsm8k(self):
6161
metrics = run_eval(args)
6262
print(f"{metrics=}")
6363

64-
self.assertGreater(metrics["accuracy"], 0.75)
64+
self.assertGreater(metrics["accuracy"], 0.74)
6565
# Wait a little bit so that the memory check happens.
6666
time.sleep(5)
6767

0 commit comments

Comments
 (0)