Merge pull request #1907 from shirou/feat/remove_binary_go_file

[disk][process][freebsd]: remove binary.go from common

Author: shirou

disk/disk_freebsd.go

@@ -154,9 +154,7 @@ func (b bintime) Compute() float64 {
 func parsedevstat(buf []byte) (devstat, error) {
 	var ds devstat
 	br := bytes.NewReader(buf)
-	//	err := binary.Read(br, binary.LittleEndian, &ds)
-	err := common.Read(br, binary.LittleEndian, &ds)
-	if err != nil {
+	if err := binary.Read(br, binary.LittleEndian, &ds); err != nil {
 		return ds, err
 	}
 

disk/disk_freebsd_386.go

@@ -50,7 +50,7 @@ type devstat struct {
 	Flags         uint32
 	Device_type   uint32
 	Priority      uint32
-	Id            *byte
+	Id            [sizeofPtr]byte
 	Sequence1     uint32
 }
 

disk/disk_freebsd_amd64.go

@@ -52,7 +52,7 @@ type devstat struct {
 	Device_type   uint32
 	Priority      uint32
 	Pad_cgo_1     [4]byte
-	ID            *byte
+	ID            [sizeofPtr]byte
 	Sequence1     uint32
 	Pad_cgo_2     [4]byte
 }

disk/disk_freebsd_arm.go

@@ -50,7 +50,7 @@ type devstat struct {
 	Flags         uint32
 	Device_type   uint32
 	Priority      uint32
-	Id            *byte
+	Id            [sizeofPtr]byte
 	Sequence1     uint32
 }
 

disk/disk_freebsd_arm64.go

@@ -114,9 +114,7 @@ func IOCountersWithContext(_ context.Context, names ...string) (map[string]IOCou
 func parseDiskstats(buf []byte) (Diskstats, error) {
 	var ds Diskstats
 	br := bytes.NewReader(buf)
-	//	err := binary.Read(br, binary.LittleEndian, &ds)
-	err := common.Read(br, binary.LittleEndian, &ds)
-	if err != nil {
+	if err := binary.Read(br, binary.LittleEndian, &ds); err != nil {
 		return ds, err
 	}
 

disk/disk_openbsd.go

@@ -1,7 +1,9 @@
 // SPDX-License-Identifier: BSD-3-Clause
 //go:build ignore
 
-// Hand writing: _Ctype_struct___0
+// Hand writing:
+//   - add _Ctype_struct___0 struct
+//   - devstat.ID *byte -> [sizeOfPtr]byte in order to use binary.Read
 
 /*
 Input to cgo -godefs.