Ignore null properties and empty psets (#668)

Author: JR-Morgan

Importers/Ifc/Speckle.Importers.Ifc.Tester2/Program.cs

@@ -10,8 +10,9 @@
 using Speckle.Sdk.Models;
 
 // Settings
-// var filePath = new FilePath(@"C:\Users\Jedd\Desktop\GRAPHISOFT_Archicad_Sample_Project-S-Office_v1.0_AC25.ifc");
-var filePath = new FilePath(@"C:\Users\Jedd\Desktop\BIM_Projekt_Golden_Nugget-Architektur_und_Ingenieurbau.ifc");
+var filePath = new FilePath(@"C:\Users\Jedd\Desktop\KLY-ZHQ-B-CPL1_CPL4-0-ELV-SD-210.ifc");
+
+// var filePath = new FilePath(@"C:\Users\Jedd\Desktop\BIM_Projekt_Golden_Nugget-Architektur_und_Ingenieurbau.ifc");
 const string PROJECT_ID = "f3a42bdf24";
 
 // Setup

Importers/Ifc/Speckle.Importers.Ifc/Converters/NodeExtensions.cs

@@ -10,13 +10,13 @@ public static class NodeExtensions
     var result = new Dictionary<string, object?>();
     foreach (var p in node.GetPropSets())
     {
-      if (p.NumProperties <= 0)
-        continue;
-
       var name = p.Name;
       if (string.IsNullOrWhiteSpace(name))
         name = $"#{p.Id}";
-      result[name] = ToSpeckleDictionary(p);
+
+      var dict = ToSpeckleDictionary(p);
+      if (dict.Count > 0) //Ignore any empty psets, since they can bloat the data size
+        result[name] = dict;
     }
 
     return result;
@@ -26,7 +26,16 @@ public static class NodeExtensions
   {
     var d = new Dictionary<string, object?>();
     foreach (var p in ps.GetProperties())
-      d[p.Name] = p.Value.ToJsonObject();
+    {
+      var value = p.Value.ToJsonObject();
+
+      if (value is not null)
+      {
+        // Ignoring null values since they'd otherwise bloat the data size of speckle models.
+        // Semantically, "null valued" and "not there" are different, but very few users care about the distinction.
+        d[p.Name] = value;
+      }
+    }
     return d;
   }
 }