Nullability of TryGet function (#217)

Author: JR-Morgan

Connectors/ArcGIS/Speckle.Connectors.ArcGIS3/Operations/Send/ArcGISRootObjectBuilder.cs

@@ -98,7 +98,7 @@ public async Task<RootObjectBuilderResult> Build(
         // don't use cache for group layers
         if (
           mapMember is not GroupLayer
-          && _sendConversionCache.TryGetValue(sendInfo.ProjectId, applicationId, out ObjectReference value)
+          && _sendConversionCache.TryGetValue(sendInfo.ProjectId, applicationId, out ObjectReference? value)
         )
         {
           converted = value;

Connectors/Autocad/Speckle.Connectors.AutocadShared/Operations/Send/AutocadRootObjectBuilder.cs

@@ -108,7 +108,7 @@ public Task<RootObjectBuilderResult> Build(
           {
             converted = instanceProxy;
           }
-          else if (_sendConversionCache.TryGetValue(sendInfo.ProjectId, applicationId, out ObjectReference value))
+          else if (_sendConversionCache.TryGetValue(sendInfo.ProjectId, applicationId, out ObjectReference? value))
           {
             converted = value;
             cacheHitCount++;

Connectors/Revit/Speckle.Connectors.RevitShared/Operations/Send/RevitRootObjectBuilder.cs

@@ -99,7 +99,7 @@ public Task<RootObjectBuilderResult> Build(
         try
         {
           Base converted;
-          if (_sendConversionCache.TryGetValue(sendInfo.ProjectId, applicationId, out ObjectReference value))
+          if (_sendConversionCache.TryGetValue(sendInfo.ProjectId, applicationId, out ObjectReference? value))
           {
             converted = value;
             cacheHitCount++;

Connectors/Rhino/Speckle.Connectors.RhinoShared/Operations/Send/RhinoRootObjectBuilder.cs

@@ -146,7 +146,7 @@ SendInfo sendInfo
       {
         converted = instanceProxies[applicationId];
       }
-      else if (_sendConversionCache.TryGetValue(sendInfo.ProjectId, applicationId, out ObjectReference value))
+      else if (_sendConversionCache.TryGetValue(sendInfo.ProjectId, applicationId, out ObjectReference? value))
       {
         converted = value;
       }

Sdk/Speckle.Connectors.Utils/Caching/ISendConversionCache.cs

@@ -1,3 +1,4 @@
+using System.Diagnostics.CodeAnalysis;
 using Speckle.Sdk.Models;
 
 namespace Speckle.Connectors.Utils.Caching;
@@ -20,5 +21,5 @@ public interface ISendConversionCache
   /// <param name="objectIds"></param>
   public void EvictObjects(IEnumerable<string> objectIds);
   public void ClearCache();
-  bool TryGetValue(string projectId, string applicationId, out ObjectReference objectReference);
+  bool TryGetValue(string projectId, string applicationId, [NotNullWhen(true)] out ObjectReference? objectReference);
 }

Sdk/Speckle.Connectors.Utils/Caching/NullSendConversionCache.cs

@@ -1,3 +1,4 @@
+using System.Diagnostics.CodeAnalysis;
 using Speckle.Sdk.Models;
 
 namespace Speckle.Connectors.Utils.Caching;
@@ -13,9 +14,13 @@ public void EvictObjects(IEnumerable<string> objectIds) { }
 
   public void ClearCache() { }
 
-  public bool TryGetValue(string projectId, string applicationId, out ObjectReference objectReference)
+  public bool TryGetValue(
+    string projectId,
+    string applicationId,
+    [NotNullWhen(true)] out ObjectReference? objectReference
+  )
   {
-    objectReference = new ObjectReference();
+    objectReference = null;
     return false;
   }
 }

Sdk/Speckle.Connectors.Utils/Caching/SendConversionCache.cs

@@ -1,3 +1,4 @@
+using System.Diagnostics.CodeAnalysis;
 using Speckle.Sdk.Models;
 
 namespace Speckle.Connectors.Utils.Caching;
@@ -25,6 +26,9 @@ public void EvictObjects(IEnumerable<string> objectIds) =>
 
   public void ClearCache() => Cache.Clear();
 
-  public bool TryGetValue(string projectId, string applicationId, out ObjectReference objectReference) =>
-    Cache.TryGetValue((applicationId, projectId), out objectReference);
+  public bool TryGetValue(
+    string projectId,
+    string applicationId,
+    [NotNullWhen(true)] out ObjectReference? objectReference
+  ) => Cache.TryGetValue((applicationId, projectId), out objectReference);
 }