[FEAT] Use proper tool name in error message, reference Osmium or osmconvert #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for the unification PR! Also noticed that while researching for your question #229 (comment). |
treee111
changed the title
treee111
pushed a commit
that referenced
this pull request
Mar 22, 2024
…convert (#232) Use proper tool name in error message, reference Osmium or osmconvert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR…
Considerations and implementations
I assume this is a left over, copy/paste error, or that the osmosis was used for this phase earlier.
Tidy up the message, so it is clear where osmium is used and where osmosis is used.
Also wonder a bit why osmconvert is used on Windows, and not Osmium, I would assume we prefer
to use the same tools on Windows and Linux, to keep things simple and similar. But that is not relevant for this PR.
How to test
Pull Request Checklist