Skip to content

Commit 24b7977

Browse files
authored
Add Name() to Logger (#1273)
Adds the `Name()` function to `Logger`, which will return the logger's name, if configured.
1 parent 1155ed3 commit 24b7977

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

logger.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -281,6 +281,12 @@ func (log *Logger) Core() zapcore.Core {
281281
return log.core
282282
}
283283

284+
// Name returns the Logger's underlying name,
285+
// or an empty string if the logger is unnamed.
286+
func (log *Logger) Name() string {
287+
return log.name
288+
}
289+
284290
func (log *Logger) clone() *Logger {
285291
copy := *log
286292
return &copy

logger_test.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -340,15 +340,17 @@ func TestLoggerNames(t *testing.T) {
340340
}
341341
log.Info("")
342342
require.Equal(t, 1, logs.Len(), "Expected only one log entry to be written.")
343-
assert.Equal(t, tt.expected, logs.AllUntimed()[0].LoggerName, "Unexpected logger name.")
343+
assert.Equal(t, tt.expected, logs.AllUntimed()[0].LoggerName, "Unexpected logger name from entry.")
344+
assert.Equal(t, tt.expected, log.Name(), "Unexpected logger name.")
344345
})
345346
withSugar(t, DebugLevel, nil, func(log *SugaredLogger, logs *observer.ObservedLogs) {
346347
for _, n := range tt.names {
347348
log = log.Named(n)
348349
}
349350
log.Infow("")
350351
require.Equal(t, 1, logs.Len(), "Expected only one log entry to be written.")
351-
assert.Equal(t, tt.expected, logs.AllUntimed()[0].LoggerName, "Unexpected logger name.")
352+
assert.Equal(t, tt.expected, logs.AllUntimed()[0].LoggerName, "Unexpected logger name from entry.")
353+
assert.Equal(t, tt.expected, log.base.Name(), "Unexpected logger name.")
352354
})
353355
}
354356
}

0 commit comments

Comments
 (0)