Skip to content

Add a possibility to use expect+su #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

7c6f434c
Copy link

@7c6f434c 7c6f434c commented Feb 7, 2019

For me, PAM is happy to let a user autenticate as the same user, but not as anyone else. So to stop running Synapse as root I added support for using expect and su instead. Works for me with Synapse 0.99.0.

@14mRh4X0r
Copy link
Owner

I'd rather not merge this, for two reasons:

  • Using su will use a different PAM identifier
  • Authenticating people using /etc/shadow can be done by adding the matrix user to the shadow group

@7c6f434c
Copy link
Author

Fair enough.

Of course, adding matrix user to shadow is not very attractive because it allows exfiltration for a GPU bruteforce if a mere arbitrary-read vulnerability is found in Synapse instead of going through su with timeouts on each failure.

I guess a proper solution would be setgid-shadow helper (with an additional benefit of not having to do -c true, and not using expect to fight su). Not sure I am currently motivated to implement it, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants