Fix current reference calculation, clarify interfaces #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mhinkkan
commented
Jun 8, 2025
mhinkkan
commented
- Fix a bug in the current reference calculation.
- Clarify the observer interfaces.
- Clarify the drive control system interfaces. Now the AC-side converter current is measured by default, even if an output LC filter is used between the converter and the machine. This change does not affect existing public control methods.
…interfaces. Modify the default vector control systems so that addition of an LC filter gets simpler.
mhinkkan
added a commit
to mhinkkan/motulator
that referenced
this pull request
Jun 10, 2025
…np.ndarray) to pass the static type checking of pyright 1.1.401 (latest). Change the PLL/observer interfaces in grid converter controls to match the changes in PR Aalto-Electric-Drives#183 for drive controls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.