Skip to content

Chartkick 5.1.0 #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 12 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,18 @@ name: build
on:
push:
branches:
- master
- main
pull_request:
branches:
- master
- main
jobs:
build:
if: "!contains(github.event.head_commit.message, '[skip ci]')"
runs-on: ubuntu-latest
strategy:
matrix:
ruby: [ '2.6', '3.0' ]
ruby: [ '3.1', '3.3.4', '3.3.5' ]
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby }}
Expand Down
2 changes: 1 addition & 1 deletion .ruby-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.0.1
3.3.5
68 changes: 38 additions & 30 deletions Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,62 +1,70 @@
PATH
remote: .
specs:
iruby-chartkick (0.3.1)
chartkick (~> 4.1.0)
iruby-chartkick (0.5.1)
chartkick (~> 5.1.0)
iruby

GEM
remote: https://rubygems.org/
specs:
chartkick (4.1.0)
chartkick (5.1.0)
data_uri (0.1.0)
diff-lcs (1.4.4)
ffi (1.15.4)
diff-lcs (1.5.1)
ffi (1.17.0)
ffi-rzmq (2.0.7)
ffi-rzmq-core (>= 1.0.7)
ffi-rzmq-core (1.0.7)
ffi
io-console (0.5.9)
irb (1.3.7)
reline (>= 0.2.7)
iruby (0.7.4)
io-console (0.7.2)
irb (1.14.1)
rdoc (>= 4.0.0)
reline (>= 0.4.2)
iruby (0.8.0)
data_uri (~> 0.1)
ffi-rzmq
irb
logger
mime-types (>= 3.3.1)
multi_json (~> 1.11)
native-package-installer
mime-types (3.3.1)
logger (1.6.1)
mime-types (3.6.0)
logger
mime-types-data (~> 3.2015)
mime-types-data (3.2021.0901)
mime-types-data (3.2024.1001)
multi_json (1.15.0)
native-package-installer (1.1.1)
rake (13.0.6)
reline (0.2.7)
native-package-installer (1.1.9)
psych (5.1.2)
stringio
rake (13.2.1)
rdoc (6.7.0)
psych (>= 4.0.0)
reline (0.5.10)
io-console (~> 0.5)
rspec (3.10.0)
rspec-core (~> 3.10.0)
rspec-expectations (~> 3.10.0)
rspec-mocks (~> 3.10.0)
rspec-core (3.10.1)
rspec-support (~> 3.10.0)
rspec-expectations (3.10.1)
rspec (3.13.0)
rspec-core (~> 3.13.0)
rspec-expectations (~> 3.13.0)
rspec-mocks (~> 3.13.0)
rspec-core (3.13.1)
rspec-support (~> 3.13.0)
rspec-expectations (3.13.3)
diff-lcs (>= 1.2.0, < 2.0)
rspec-support (~> 3.10.0)
rspec-mocks (3.10.2)
rspec-support (~> 3.13.0)
rspec-mocks (3.13.2)
diff-lcs (>= 1.2.0, < 2.0)
rspec-support (~> 3.10.0)
rspec-support (3.10.2)
rspec-support (~> 3.13.0)
rspec-support (3.13.1)
stringio (3.1.1)

PLATFORMS
x86_64-darwin-20
x86_64-linux
ruby

DEPENDENCIES
bundler
iruby-chartkick!
rake (~> 13.0)
rspec (~> 3.0)
rake (~> 13.2.1)
rspec (~> 3.13.0)

BUNDLED WITH
2.2.15
2.5.21
10 changes: 5 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,24 +11,24 @@ You like writing [Ruby within Juypter](https://github.com/SciRuby/iruby/) notebo
### Usage

You can either include the module `IRuby::Chartkick` and use the wrapper methods, like `line_chart`:

```ruby
include IRuby::Chartkick

data = {
2019 => 1,
2020 => 122,
2021 => 34
}

line_chart(data)
```

Or you use the chart wrapper classes directly:
Or you use the chart wrapper classes directly:

```ruby
include IRuby::Chartkick

data = {
2019 => 1,
2020 => 122,
Expand Down
6 changes: 3 additions & 3 deletions iruby-chartkick.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@ Gem::Specification.new do |spec|
spec.require_paths = ["lib"]

spec.add_runtime_dependency "iruby"
spec.add_dependency "chartkick", "~> 4.1.0"
spec.add_dependency "chartkick", "~> 5.1.0"

spec.add_development_dependency "bundler"
spec.add_development_dependency "rake", "~> 13.0"
spec.add_development_dependency "rspec", "~> 3.0"
spec.add_development_dependency "rake", "~> 13.2.1"
spec.add_development_dependency "rspec", "~> 3.13.0"
end
2 changes: 1 addition & 1 deletion lib/iruby/chartkick/version.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true
module IRuby
module Chartkick
VERSION = "0.3.1"
VERSION = "0.5.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to skip v0.4.0? Would be more logical to jump to this, wouldn't it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea was to leave it similar to the chartkick version 😅

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing out 👍 I somehow disagree here, because I think keeping a coherent own version history makes more sense to avoid confusion - but - don't worry - I can live with that decision 😉 🫶

end
end
Loading