Skip to content

feat: update data-grid to use CSS subgrid. #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

feat: update data-grid to use CSS subgrid. #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3a09ffd
update data grid styles to use subgrid.
KingOfTac Jan 8, 2024
07cfefa
Change files
KingOfTac Jan 8, 2024
7a2cbfe
remove unrelated file that was accidentally committed
KingOfTac Jan 8, 2024
4c42f92
update grid styles
KingOfTac Jan 9, 2024
c8c8b85
quotes
KingOfTac Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@adaptive-web-adaptive-web-components-cc7e748e-c4f1-4ef1-88bf-b0c93ae66117.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "update data grid styles to use subgrid.",
"packageName": "@adaptive-web/adaptive-web-components",
"email": "32497422+KingOfTac@users.noreply.github.com",
"dependentChangeType": "patch"
}
1 change: 1 addition & 0 deletions packages/adaptive-web-components/src/components/data-grid-cell/data-grid-cell.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { css, ElementStyles } from "@microsoft/fast-element";
*/
export const templateStyles: ElementStyles = css`
:host {
grid-column: ${x => x.gridColumn ?? 0};
overflow: hidden;
white-space: nowrap;
}
Expand Down
4 changes: 4 additions & 0 deletions packages/adaptive-web-components/src/components/data-grid-row/data-grid-row.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import {
highlightStrokeReadableRest,
neutralFillSubtleRest,
} from "@adaptive-web/adaptive-ui/reference";
import type { FASTDataGridRow } from "@microsoft/fast-foundation";
import { heightNumber } from "../../styles/index.js";

/**
Expand All @@ -14,6 +15,9 @@ import { heightNumber } from "../../styles/index.js";
export const templateStyles: ElementStyles = css`
:host {
display: grid;
grid-template-columns: subgrid;
grid-column: 1 / span all;
grid-auto-flow: row;
width: 100%;
}

Expand Down
8 changes: 5 additions & 3 deletions packages/adaptive-web-components/src/components/data-grid/data-grid.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,16 @@
import { css, ElementStyles } from "@microsoft/fast-element";
import { FASTDataGrid } from "@microsoft/fast-foundation";

/**
* Basic layout styling associated with the anatomy of the template.
* @public
*/
export const templateStyles: ElementStyles = css`
export const templateStyles: ElementStyles = css<FASTDataGrid>/* CSS */`
:host {
display: flex;
display: grid;
position: relative;
flex-direction: column;
grid-auto-flow: row;
grid-template-columns: repeat(${x => x.columnDefinitions?.length ?? 1}, 1fr);
}

:host([selection-mode="multi-row"]) {
Expand Down
2 changes: 1 addition & 1 deletion packages/adaptive-web-components/src/components/data-grid/data-grid.template.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { ElementViewTemplate } from "@microsoft/fast-element";
import { dataGridTemplate, FASTDataGrid } from "@microsoft/fast-foundation";
import { ComponentAnatomy, Interactivity } from "@adaptive-web/adaptive-ui";
import { DesignSystem } from "../../design-system.js";
import { composeDataGridRow } from '../data-grid-row/index.js';
import { composeDataGridRow } from "../data-grid-row/index.js";

/**
* @public
Expand Down