Skip to content

Add 1909 and ltsc2019 configs to hotspot and openj9 official configs #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Conversation

slide
Copy link
Contributor

@slide slide commented Jul 13, 2020

Added 1909 and ltsc2019 configs to hotspot and openj9 official config files. As a not, nanoserver has not been added to openj9 configs because there were some issues last time I tried openj9 on nanoserver. I am hoping to enable tests for the openj9 team on nanoserver, but have yet to submit a PR for it.

@karianna karianna added this to the July 2020 milestone Jul 14, 2020
@karianna karianna modified the milestones: July 2020, August 2020 Aug 4, 2020
@karianna karianna modified the milestones: August 2020, September 2020 Sep 15, 2020
@karianna karianna modified the milestones: September 2020, October 2020 Oct 1, 2020
@karianna karianna modified the milestones: October 2020, November 2020 Nov 5, 2020
@slide
Copy link
Contributor Author

slide commented Nov 19, 2020

Any update on this?

@karianna karianna requested a review from dinogun November 19, 2020 22:09
@karianna
Copy link
Member

Apologies! This change LGTM but I'd like to defer to @dinogun to make sure we're happy supporting these platforms going forward.

@slide
Copy link
Contributor Author

slide commented Nov 20, 2020

Would the project be open to building docker images and publishing them from GitHub actions? This would allow building and publishing more variants to at least the "unofficial" repos on docker hub. The windows support right now is quite a bit behind where the linux images are.

@karianna
Copy link
Member

@dinogun - OK to land this?

@dinogun
Copy link
Collaborator

dinogun commented Nov 24, 2020

Would the project be open to building docker images and publishing them from GitHub actions? This would allow building and publishing more variants to at least the "unofficial" repos on docker hub. The windows support right now is quite a bit behind where the linux images are.

@slide apologies for the tardiness with this PR. Unfortunately we do not have a physical windows docker setup at Adopt and it is primarily because docker is extremely flaky on windows and we ran into a number of issues trying to keep it up and running. So now we have switched to doing the builds only at the official repo. However it is pretty difficult when we run into issues such as this - We had to turn off Windows nanoserver support and no easy way to even test fixes. @bharathappali is now working to have a local windows setup that can help us here.

In the meanwhile if you can help with the github actions based builds that is definitely very useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants