-
Notifications
You must be signed in to change notification settings - Fork 234
Add updated release process in RELEASE.md #506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs some Markdown formatting for headings etc. Suggest using VS Code or similar IDE with some linting :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sounds like something that shoulkd be added to the steps at https://github.com/sxa/openjdk-build/blob/master/RELEASING.md#steps-for-every-version if we can shorten it a little.
Also presumably there are certain access levels and/or docker tokens required for these to work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more suggestions based in addition to my previous ones after reading it again.
|
||
Official images are maintained by the Docker community and updates are done through the official github repo at .... This requires an update to the Dockerfiles in this repo and a subsequent PR at the official repo with the commit id that has all the Dockerfile updates. | ||
|
||
* Generate the updated dockerfiles |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is this different to what the multiarch jobs do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The multiarch jobs dont update the Dockerfiles in the repo. (They update the Dockerfiles locally as part of the Jenkins job). We need to update the Dockerfiles in the repo and then point to them from the official github repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a description of where we are at the moment this looks good. We'll need to integrate it more with the top level releasing document to ensure a non-fragmented experience for our release teams.
No description provided.