Skip to content

Add updated release process in RELEASE.md #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 14, 2021

Conversation

dinogun
Copy link
Collaborator

@dinogun dinogun commented Feb 4, 2021

No description provided.

@karianna karianna added this to the February 2021 milestone Feb 10, 2021
Copy link
Member

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs some Markdown formatting for headings etc. Suggest using VS Code or similar IDE with some linting :-)

@sxa sxa self-requested a review February 11, 2021 14:16
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds like something that shoulkd be added to the steps at https://github.com/sxa/openjdk-build/blob/master/RELEASING.md#steps-for-every-version if we can shorten it a little.

Also presumably there are certain access levels and/or docker tokens required for these to work?

@karianna karianna modified the milestones: February 2021, March 2021 Mar 1, 2021
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more suggestions based in addition to my previous ones after reading it again.


Official images are maintained by the Docker community and updates are done through the official github repo at .... This requires an update to the Dockerfiles in this repo and a subsequent PR at the official repo with the commit id that has all the Dockerfile updates.

* Generate the updated dockerfiles
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this different to what the multiarch jobs do?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The multiarch jobs dont update the Dockerfiles in the repo. (They update the Dockerfiles locally as part of the Jenkins job). We need to update the Dockerfiles in the repo and then point to them from the official github repo.

@dinogun dinogun marked this pull request as ready for review April 9, 2021 09:51
@dinogun
Copy link
Collaborator Author

dinogun commented Apr 9, 2021

@karianna @sxa Should be ready for review now

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a description of where we are at the moment this looks good. We'll need to integrate it more with the top level releasing document to ensure a non-fragmented experience for our release teams.

@dinogun dinogun merged commit 4f1c550 into AdoptOpenJDK:master Apr 14, 2021
@karianna karianna modified the milestones: March 2021, April 2021 Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants