Skip to content

add April PSU updates #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2021
Merged

add April PSU updates #554

merged 1 commit into from
Apr 28, 2021

Conversation

gdams
Copy link
Member

@gdams gdams commented Apr 23, 2021

No description provided.

@dinogun
Copy link
Collaborator

dinogun commented Apr 23, 2021

@bharathappali Can you please investigate the OpenJ9 SCC PR check failures and update your findings here

@bharathappali
Copy link
Collaborator

I have tried to build alpine and ubuntu images of jdk 8 release and figured out that the OpenJ9 slim images are facing the issue of Selected VM [default] does not exist. after running the slim script

Before running slim script:

bharathappali@bharathappali-T590:~/Documents/workstation/git-clones/testspace/openjdk$ ./bin/java -version
openjdk version "1.8.0_292"
OpenJDK Runtime Environment (build 1.8.0_292-b10)
Eclipse OpenJ9 VM (build openj9-0.26.0, JRE 1.8.0 Linux amd64-64-Bit Compressed References 20210421_1000 (JIT enabled, AOT enabled)
OpenJ9   - b4cc246d9
OMR      - 162e6f729
JCL      - 2a5e268814 based on jdk8u292-b10)

After running slim script:

bharathappali@bharathappali-T590:~/Documents/workstation/git-clones/testspace/openjdk$ ./bin/java -version
Selected VM [default] does not exist.
This JVM package includes both the '-Xcompressedrefs' and the '-Xnocompressedrefs' configurations, however the VM directory could not be found. Please download the latest JVM package or build with the most recent changes and run the JVM again.

I feel the issue is we are stripping of something important from the OpenJ9 package.

@pshipton
Copy link

pshipton commented Apr 27, 2021

It appears the jre/lib/amd64/default directory has been removed. This directory wasn't required in the past for compressed refs builds (only the compressedrefs directory was required), however now that the builds use mixed refs (both compressed refs and large heap in the same build), the default directory is required.

@bharathappali
Copy link
Collaborator

@pshipton yes its due to removal of default directory. In my experiment I saw the JVM coming up after commenting rm -rf default/ in jre_lib_files. Not sure which file JVM is missing among these

j9ddr.dat           java_fr.properties  java_pl.properties     java_sl.properties     libcuda4j29.so        libj9gc_full29.so   libj9jvmti29.so  libj9vm29.so        libjclse29.so
java_ca.properties  java_hu.properties  java.properties        java_tr.properties     libj9dmp29.so         libj9hookable29.so  libj9prt29.so    libj9vmchk29.so     libjvm.so
java_cs.properties  java_it.properties  java_pt_BR.properties  java_zh_CN.properties  libj9gc29.so          libj9jextract.so    libj9shr29.so    libj9vrb29.so       libomrsig.so
java_de.properties  java_ja.properties  java_ru.properties     java_zh.properties     libj9gcchk29.so       libj9jit29.so       libj9thr29.so    libj9vrb_full29.so  options.default
java_es.properties  java_ko.properties  java_sk.properties     java_zh_TW.properties  libj9gcchk_full29.so  libj9jnichk29.so    libj9trc29.so    libj9zlib29.so

Copy link
Collaborator

@dinogun dinogun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dinogun dinogun merged commit c5102c1 into AdoptOpenJDK:master Apr 28, 2021
@gdams gdams deleted the aprilpsu branch April 28, 2021 10:33
@karianna karianna added this to the April 2021 milestone Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants