Added cpp2 code generator #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyrillemidingoyi
merged commit 174d673
into
AgriculturalModelExchangeInitiative:master
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Cyrille,
as I mentioned somewhen, I added some time ago as an experiment a cpp2 code generator, which creates pure structs and no accessors for state, rate, exogeneous and auxiliary structs.
I fixed now all the issues and at least for the current temperature models it generates correct code and running that code gives the same results as the cpp generated code.
Nevertheless also the cpp2 code generator is not really satisfying and in my opinion we need to update the general code generation approach for nested composites. I might try this for C++ code, but for the moment I just would like to get the cpp2 code added to the repository, so it's no in a local branch of our (ZALF) copy of PyCrop2ML.
Best,
Michael