-
Notifications
You must be signed in to change notification settings - Fork 4
Add version
command
#29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think the ASCII text banner is overkill, we should just have a simple response like other Kubernetes related tools: % kubectl version
Client Version: v1.33.0
Kustomize Version: v5.6.0
Server Version: v1.30.11-eks-bcf3d70 % argocd version
argocd: v2.14.11+8283115.dirty
BuildDate: 2025-04-22T17:03:17Z
GitCommit: 82831155c2c1873b3b5d19449bfa3970dab9ce24
GitTreeState: dirty
GoVersion: go1.24.2
Compiler: gc
Platform: darwin/arm64 % helm version
version.BuildInfo{Version:"v3.17.3", GitCommit:"e4da49785aa6e6ee2b86efd5dd9e43400318262b", GitTreeState:"clean", GoVersion:"go1.24.2"} |
This is subjective. Netshoot has it in its main output, for instance. (https://github.com/nicolaka/netshoot/blob/2908a1a68ab1507fbe122b492151ddfb8db3e150/README.md?plain=1#L105) |
I personally like the banner, I think a lot of new projects/command line tools have this nowadays. I do agree that perhaps the name is a bit too long, so making the banner a bit too long, but I think the design looks nice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go with the banner for now.
Example of running the version command on a local build:
Also updated the readme and formatted other documents.