Skip to content

Add version command #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 13, 2025
Merged

Add version command #29

merged 6 commits into from
May 13, 2025

Conversation

nirmalsunny
Copy link
Contributor

Example of running the version command on a local build:

./dist/kubearchinspect_darwin_arm64_v8.0/kubearchinspect version

  _  __     _                            _     _____                           _   
 | |/ /    | |            /\            | |   |_   _|                         | |  
 | ' /_   _| |__   ___   /  \   _ __ ___| |__   | |  _ __  ___ _ __   ___  ___| |_ 
 |  <| | | | '_ \ / _ \ / /\ \ | '__/ __| '_ \  | | | '_ \/ __| '_ \ / _ \/ __| __|
 | . \ |_| | |_) |  __// ____ \| | | (__| | | |_| |_| | | \__ \ |_) |  __/ (__| |_ 
 |_|\_\__,_|_.__/ \___/_/    \_\_|  \___|_| |_|_____|_| |_|___/ .__/ \___|\___|\__|
                                                              | |                  
                                                              |_|                  
Version: 0.5.0-SNAPSHOT-8b62a6d
Commit: 8b62a6d48390293c5b676268cbcf1cf35ace15aa
Built at: 2025-04-30T10:19:06Z

Also updated the readme and formatted other documents.

@nirmalsunny nirmalsunny requested a review from a team as a code owner April 30, 2025 10:45
@nirmalsunny nirmalsunny changed the title Version cmd Add version command Apr 30, 2025
@sm-powell
Copy link
Contributor

I think the ASCII text banner is overkill, we should just have a simple response like other Kubernetes related tools:

% kubectl version
Client Version: v1.33.0
Kustomize Version: v5.6.0
Server Version: v1.30.11-eks-bcf3d70
% argocd version
argocd: v2.14.11+8283115.dirty
  BuildDate: 2025-04-22T17:03:17Z
  GitCommit: 82831155c2c1873b3b5d19449bfa3970dab9ce24
  GitTreeState: dirty
  GoVersion: go1.24.2
  Compiler: gc
  Platform: darwin/arm64
% helm version
version.BuildInfo{Version:"v3.17.3", GitCommit:"e4da49785aa6e6ee2b86efd5dd9e43400318262b", GitTreeState:"clean", GoVersion:"go1.24.2"}

@nirmalsunny
Copy link
Contributor Author

I think the ASCII text banner is overkill, we should just have a simple response like other Kubernetes related tools:

% kubectl version
Client Version: v1.33.0
Kustomize Version: v5.6.0
Server Version: v1.30.11-eks-bcf3d70
% argocd version
argocd: v2.14.11+8283115.dirty
  BuildDate: 2025-04-22T17:03:17Z
  GitCommit: 82831155c2c1873b3b5d19449bfa3970dab9ce24
  GitTreeState: dirty
  GoVersion: go1.24.2
  Compiler: gc
  Platform: darwin/arm64
% helm version
version.BuildInfo{Version:"v3.17.3", GitCommit:"e4da49785aa6e6ee2b86efd5dd9e43400318262b", GitTreeState:"clean", GoVersion:"go1.24.2"}

This is subjective. Netshoot has it in its main output, for instance. (https://github.com/nicolaka/netshoot/blob/2908a1a68ab1507fbe122b492151ddfb8db3e150/README.md?plain=1#L105)

@biancabunaciu
Copy link

I think the ASCII text banner is overkill, we should just have a simple response like other Kubernetes related tools:

I personally like the banner, I think a lot of new projects/command line tools have this nowadays. I do agree that perhaps the name is a bit too long, so making the banner a bit too long, but I think the design looks nice.

Copy link
Contributor

@sm-powell sm-powell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go with the banner for now.

@nirmalsunny nirmalsunny merged commit d64651f into main May 13, 2025
3 checks passed
@nirmalsunny nirmalsunny deleted the version-cmd branch May 13, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants