Skip to content

Test/time bits 32 #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2025
Merged

Test/time bits 32 #71

merged 2 commits into from
Apr 8, 2025

Conversation

GHakansson
Copy link
Contributor

@GHakansson GHakansson commented Apr 7, 2025

Describe your changes

The SDK was incorrectly building with 64-bit time and file offset types for armv7hf, potentially causing runtime issues and unexpected behavior on 32-bit hardware.

Solution forces all time and file offset types to properly use 32-bit, matching the actual architecture capabilities.

Issue ticket number and link

ECODEVT-1376

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have verified that the code builds perfectly fine on my local system

@GHakansson GHakansson requested a review from a team as a code owner April 7, 2025 12:16
Copy link
Contributor

@johan-hultberg-work johan-hultberg-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes looks fine to me. However, please update the description of the PR with some more context.

@GHakansson GHakansson merged commit 097e4e2 into main Apr 8, 2025
2 checks passed
@GHakansson GHakansson deleted the test/time_bits_32 branch April 8, 2025 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants