Skip to content

Milestone 1.8.0: Simplify Infrastructure & Sample Creation #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Aug 1, 2025

Conversation

simonkurtz-MSFT
Copy link
Member

Samples can now be executed without having to have an infrastructure created previously. This is a big quality-of-life change that reduces complexity and accelerates users.

The PR also includes a lot of clean up and homogenization of code and documentation.

@simonkurtz-MSFT simonkurtz-MSFT requested a review from Copilot August 1, 2025 18:00
@simonkurtz-MSFT simonkurtz-MSFT self-assigned this Aug 1, 2025
@simonkurtz-MSFT simonkurtz-MSFT added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Aug 1, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces "Milestone 1.8.0: Simplify Infrastructure & Sample Creation" which allows samples to be executed without requiring pre-created infrastructure, significantly reducing complexity for users. The changes include comprehensive code standardization, new testing infrastructure, and enhanced functionality for automatic infrastructure selection and creation.

Key Changes:

  • Comprehensive quote style standardization from double quotes to single quotes across Python test files
  • Addition of extensive test coverage for new infrastructure auto-discovery functionality
  • Implementation of automatic infrastructure selection when target infrastructure doesn't exist
  • Enhanced cleanup and infrastructure management capabilities

Reviewed Changes

Copilot reviewed 33 out of 33 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/python/test_utils.py Extensive quote standardization and major new test coverage for infrastructure selection, cleanup functionality, and auto-discovery capabilities
tests/python/test_users.py Quote style standardization from double to single quotes throughout
tests/python/test_charts.py New comprehensive test file for Charts module functionality with complete test coverage
tests/python/test_authfactory.py Quote style standardization from double to single quotes
tests/python/test_apimtypes.py Quote style standardization from double to single quotes
tests/python/test_apimtesting.py New comprehensive test file for ApimTesting module with full test coverage
tests/python/test_apimrequests.py Quote style standardization and significant expansion of test coverage for async operations
tests/python/conftest.py Quote style standardization from double to single quotes
tests/Test-Matrix.md Restructured to simplified printable format with checkbox symbols
tests/README.md New file providing comprehensive testing documentation and procedures
Comments suppressed due to low confidence (1)

tests/python/test_utils.py:665

  • The test case was modified to remove special characters (quotes) from the test data, which may reduce test coverage for edge cases involving special character handling in resource group tags.
    tags = {'description': 'This is a test environment', 'owner': 'john@company.com'}

Copy link

github-actions bot commented Aug 1, 2025

Python 3.13 Test Results

283 tests  +73   283 ✅ +73   5s ⏱️ +4s
  1 suites ± 0     0 💤 ± 0 
  1 files   ± 0     0 ❌ ± 0 

Results for commit 73cf964. ± Comparison against base commit c7059e1.

This pull request removes 1 and adds 74 tests. Note that renamed tests count towards both.
test_utils ‑ test_cleanup_deployment_single
test_apimrequests ‑ test_headers_setter
test_apimrequests ‑ test_multi_request_non_json_response
test_apimrequests ‑ test_multi_request_path_without_leading_slash
test_apimrequests ‑ test_multi_request_with_message
test_apimrequests ‑ test_poll_async_operation_in_progress_then_success
test_apimrequests ‑ test_poll_async_operation_request_exception
test_apimrequests ‑ test_poll_async_operation_success
test_apimrequests ‑ test_poll_async_operation_timeout
test_apimrequests ‑ test_poll_async_operation_unexpected_status
test_apimrequests ‑ test_print_response_non_200_status
…

Copy link

github-actions bot commented Aug 1, 2025

Python 3.12 Test Results

283 tests  +73   283 ✅ +73   6s ⏱️ +5s
  1 suites ± 0     0 💤 ± 0 
  1 files   ± 0     0 ❌ ± 0 

Results for commit 73cf964. ± Comparison against base commit c7059e1.

This pull request removes 1 and adds 74 tests. Note that renamed tests count towards both.
test_utils ‑ test_cleanup_deployment_single
test_apimrequests ‑ test_headers_setter
test_apimrequests ‑ test_multi_request_non_json_response
test_apimrequests ‑ test_multi_request_path_without_leading_slash
test_apimrequests ‑ test_multi_request_with_message
test_apimrequests ‑ test_poll_async_operation_in_progress_then_success
test_apimrequests ‑ test_poll_async_operation_request_exception
test_apimrequests ‑ test_poll_async_operation_success
test_apimrequests ‑ test_poll_async_operation_timeout
test_apimrequests ‑ test_poll_async_operation_unexpected_status
test_apimrequests ‑ test_print_response_non_200_status
…

@simonkurtz-MSFT simonkurtz-MSFT merged commit bc24d0b into main Aug 1, 2025
8 checks passed
@simonkurtz-MSFT simonkurtz-MSFT deleted the milestone-1.8.0/main branch August 1, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant