Skip to content

Conversation

brsteph
Copy link
Contributor

@brsteph brsteph commented Jun 26, 2024

Overview/Summary

This PR is to fix issues identified with deploying networks after the multi-region update and recent product changes. Discovered in: https://dev.azure.com/CSUSolEng/Azure%20Landing%20Zones/_workitems/edit/35833

Core issues are:

  • Attempts to peer networks incorrectly - the deployment was trying to peer ID spoke networks incorrectly, and was also trying to peer hubs even when one hub is in use.
  • Zonal IPs for Gateway SKUs - A new zone property was needed for zonal gateway public IPs.
  • Issues with secondary region DNS proxy configuration on the Firewall.

This PR fixes/adds/changes/removes

  1. Adjusted the logic to better limit the parameters used to initiate a secondary region deployment.

Breaking Changes

  1. None

Testing Evidence

Confirmation of Gateway Deployment:
image

Confirmation of single region deployment:

image

ID Spoke and Peering:

image
image

Confirmation of DNS Proxy for Secondary Region:
image

Testing URLs

The below URLs can be updated where the placeholders are, look for {YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also} & {YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also}, to allow you to test your portal deployment experience.

Please also replace the curly brackets on the placeholders {}

Azure Public

Deploy To Azure

Azure US Gov (Fairfax)

Deploy To Azure

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Ensured contribution guidance is followed.
  • Updated relevant and associated documentation.
  • Updated the "What's New?" wiki page (located: /docs/wiki/whats-new.md) (N/A for bugfix)

@brsteph brsteph marked this pull request as ready for review June 28, 2024 19:28
@brsteph brsteph requested a review from a team as a code owner June 28, 2024 19:28
@brsteph
Copy link
Contributor Author

brsteph commented Jun 28, 2024

@jtracey93 - Updated!

@jtracey93 jtracey93 added the PR: Safe to test 🧪 PRs can run more advanced tests that may deploy or access environments label Jul 1, 2024
@jtracey93 jtracey93 closed this Jul 1, 2024
@jtracey93 jtracey93 reopened this Jul 1, 2024
@jtracey93 jtracey93 merged commit f775451 into Azure:main Jul 1, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Safe to test 🧪 PRs can run more advanced tests that may deploy or access environments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants