Skip to content

Removing Effect1 parameter and usage. Updated parameter value #1923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: policy-refresh-h2fy25
Choose a base branch
from
Open

Removing Effect1 parameter and usage. Updated parameter value #1923

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b958c41
Removing Effect1 parameter and usage. Replaced with Effect
SebastianClaesson Feb 11, 2025
ec23f2c
updating readme
SebastianClaesson Feb 11, 2025
18907ff
updating with regionName
SebastianClaesson Feb 11, 2025
d168644
feat: add may 2025 community call (#1989)
jtracey93 May 7, 2025
89e77a1
Merge branch 'main' into main
Springstone May 13, 2025
dadc029
Update Deny-MgmtPorts-From-Internet.json (#1992)
leticiavalladares May 14, 2025
2fcf212
Merge branch 'Azure:main' into main
SebastianClaesson May 14, 2025
917da96
Updating to version 3.0.0
SebastianClaesson May 14, 2025
14e5005
Adding note under policy may 2025
SebastianClaesson May 14, 2025
240a557
Rebuilt the deployment payload
SebastianClaesson May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/wiki/Whats-new.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@ Here's what's changed in Enterprise Scale/Azure Landing Zones:

#### Tooling

- Updated the initiative [Deploy-Private-DNS-Zones](https://www.azadvertizer.net/azpolicyinitiativesadvertizer/Deploy-Private-DNS-Zones.html), Removing the 'Effect1' parameter from the policy set "Deploy-Private-DNS-Zones" and using the "Effect" parameter.
- Update eventgrid topic and domain name DNS zone name in the initiative [Deploy-Private-DNS-Zones](https://www.azadvertizer.net/azpolicyinitiativesadvertizer/Deploy-Private-DNS-Zones.html) to also contain regionName.
- Updated the ***Baseline alerts and monitoring*** integration section in the portal accelerator to deploy the latest release of AMBA (2025-02-05). To read more on the changes, see the [What's new](https://aka.ms/amba/alz/whatsnew) page in the AMBA documentation.

### January 2025
Expand Down
22 changes: 5 additions & 17 deletions src/resources/Microsoft.Authorization/policySetDefinitions/Deploy-Private-DNS-Zones.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,8 +142,8 @@
"azureDataFactoryPrivateDnsZoneId": "privatelink.datafactory.azure.net",
"azureDatabricksPrivateDnsZoneId": "privatelink.azuredatabricks.net",
"azureDiskAccessPrivateDnsZoneId": "privatelink.blob.core.windows.net",
"azureEventGridDomainsPrivateDnsZoneId": "privatelink.eventgrid.azure.net",
"azureEventGridTopicsPrivateDnsZoneId": "privatelink.eventgrid.azure.net",
"azureEventGridDomainsPrivateDnsZoneId": "{regionName}.privatelink.eventgrid.azure.net",
"azureEventGridTopicsPrivateDnsZoneId": "{regionName}.privatelink.eventgrid.azure.net",
"azureEventHubNamespacePrivateDnsZoneId": "privatelink.servicebus.windows.net",
"azureFilePrivateDnsZoneId": "privatelink.afs.azure.net",
"azureHDInsightPrivateDnsZoneId": "privatelink.azurehdinsight.net",
Expand Down Expand Up @@ -808,18 +808,6 @@
"Disabled"
],
"defaultValue": "DeployIfNotExists"
},
"effect1": {
"type": "string",
"metadata": {
"displayName": "Effect",
"description": "Enable or disable the execution of the policy"
},
"allowedValues": [
"deployIfNotExists",
"Disabled"
],
"defaultValue": "deployIfNotExists"
}
},
"policyDefinitions": [
Expand Down Expand Up @@ -1434,7 +1422,7 @@
"value": "[[if(equals(parameters('dnsZoneSubscriptionId'), ''), parameters('azureEventGridTopicsPrivateDnsZoneId'), format('/subscriptions/{0}/resourceGroups/{1}/providers/{2}/{3}', parameters('dnsZoneSubscriptionId'), toLower(parameters('dnsZoneResourceGroupName')), parameters('dnsZoneResourceType'), replace(replace(parameters('dnsZoneNames').azureEventGridTopicsPrivateDnsZoneId, '{regionName}', parameters('dnsZoneRegion')), '{regionCode}', parameters('dnzZoneRegionShortNames')[parameters('dnsZoneRegion')])))]"
},
"effect": {
"value": "[[parameters('effect1')]"
"value": "[[parameters('effect')]"
}
},
"groupNames": []
Expand Down Expand Up @@ -1476,7 +1464,7 @@
"value": "[[if(equals(parameters('dnsZoneSubscriptionId'), ''), parameters('azureIotHubsPrivateDnsZoneId'), format('/subscriptions/{0}/resourceGroups/{1}/providers/{2}/{3}', parameters('dnsZoneSubscriptionId'), toLower(parameters('dnsZoneResourceGroupName')), parameters('dnsZoneResourceType'), replace(replace(parameters('dnsZoneNames').azureIotHubsPrivateDnsZoneId, '{regionName}', parameters('dnsZoneRegion')), '{regionCode}', parameters('dnzZoneRegionShortNames')[parameters('dnsZoneRegion')])))]"
},
"effect": {
"value": "[[parameters('effect1')]"
"value": "[[parameters('effect')]"
}
},
"groupNames": []
Expand All @@ -1490,7 +1478,7 @@
"value": "[[if(equals(parameters('dnsZoneSubscriptionId'), ''), parameters('azureEventGridDomainsPrivateDnsZoneId'), format('/subscriptions/{0}/resourceGroups/{1}/providers/{2}/{3}', parameters('dnsZoneSubscriptionId'), toLower(parameters('dnsZoneResourceGroupName')), parameters('dnsZoneResourceType'), replace(replace(parameters('dnsZoneNames').azureEventGridDomainsPrivateDnsZoneId, '{regionName}', parameters('dnsZoneRegion')), '{regionCode}', parameters('dnzZoneRegionShortNames')[parameters('dnsZoneRegion')])))]"
},
"effect": {
"value": "[[parameters('effect1')]"
"value": "[[parameters('effect')]"
}
},
"groupNames": []
Expand Down