Skip to content

[A11y] Add aria-label for upload progress #5916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 2, 2025

Conversation

jimchou-dev
Copy link
Member

@jimchou-dev jimchou-dev commented Jun 27, 2025

What

  • Add aria-label for upload progress
image

Why

How Tested

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

Copy link
Contributor

Copy link
Contributor

github-actions bot commented Jun 27, 2025

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 29652 / 47347
62.62%
29652 / 47347
62.62%
816 / 1493
54.65%
2442 / 3867
63.14%
Current 29654 / 47349
62.62%
29654 / 47349
62.62%
816 / 1493
54.65%
2442 / 3868
63.13%
Diff 2 / 2
0%
2 / 2
0%
0 / 0
0%
0 / 1
-0.01%

Copy link
Contributor

github-actions bot commented Jun 27, 2025

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 58349 / 94931
61.46%
58349 / 94931
61.46%
1187 / 2716
43.7%
3359 / 5759
58.32%
Current 58444 / 94939
61.55%
58444 / 94939
61.55%
1187 / 2716
43.7%
3397 / 5787
58.7%
Diff 95 / 8
0.09%
95 / 8
0.09%
0 / 0
0%
38 / 28
0.38%

Copy link
Contributor

github-actions bot commented Jul 2, 2025

Copy link
Contributor

github-actions bot commented Jul 2, 2025

📦 Chat bundle size

Bundle Base Size (bytes) Current Size (bytes) Change Delta (bytes)
build.bundle.js 1779453 1779776 ⚠️ increased 323
110.bundle.js 365689 365689 ➖ unchanged 0
450.bundle.js 4455 4455 ➖ unchanged 0
82.bundle.js 28303 28303 ➖ unchanged 0
91.bundle.js 4055 4104 ⚠️ increased 49

Total change: +372 B ⚠️

Copy link
Contributor

github-actions bot commented Jul 2, 2025

📦 Calling bundle size

Bundle Base Size (bytes) Current Size (bytes) Change Delta (bytes)
build.bundle.js 6604180 6604274 ⚠️ increased 94
398.bundle.js 12413560 12413560 ➖ unchanged 0

Total change: +94 B ⚠️

Copy link
Contributor

github-actions bot commented Jul 2, 2025

📦 CallWithChat bundle size

Bundle Base Size (bytes) Current Size (bytes) Change Delta (bytes)
build.bundle.js 7579425 7579748 ⚠️ increased 323
398.bundle.js 12413574 12413574 ➖ unchanged 0
399.bundle.js 362421 362421 ➖ unchanged 0
450.bundle.js 4471 4471 ➖ unchanged 0
82.bundle.js 28319 28319 ➖ unchanged 0
91.bundle.js 4071 4120 ⚠️ increased 49

Total change: +372 B ⚠️

Copy link
Contributor

github-actions bot commented Jul 2, 2025

@jimchou-dev jimchou-dev merged commit 2b322d6 into main Jul 2, 2025
41 checks passed
@jimchou-dev jimchou-dev deleted the jimchou/a11y-upload-progress branch July 2, 2025 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants