Fix for OnFetchProfile display name in chat for Teams user #5924
Conversation
📦 Chat bundle size
Total change: +546 B |
📦 CallWithChat bundle size
Total change: +686 B |
📦 Calling bundle size
Total change: +0 B ➖ |
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-yafjpwoznd.chromatic.com/ |
prabhjot-msft
requested review from
JamesBurnside,
alkwa-msft,
dmceachernmsft,
carocao-msft,
edwardlee-msft,
mgamis-msft,
jimchou-dev,
vhuseinova-msft,
Leah-Xia-Microsoft,
jpeng-ms,
waynemo,
emlynmac,
JoshuaLai and
palatter
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-qwzldzydoc.chromatic.com/ |
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-qtooizloss.chromatic.com/ |
packages/react-composites/src/composites/ChatComposite/adapter/OnFetchProfileCallback.ts
Show resolved
Hide resolved
| for (const message of Object.values(chatMessages)) { | ||
| if (message?.sender) { | ||
| const senderId = | ||
| message.sender.kind === 'microsoftTeamsUser' && message.sender.rawId |
There was a problem hiding this comment.
Is there a way to simplify this ternary? its really hard to follow
There was a problem hiding this comment.
Maybe a helper function getSenderId(message) and use a series of if statements that return early in that helper function?
| } | ||
| } | ||
| } | ||
| }; |
There was a problem hiding this comment.
nit: As an optimization, instead of a for loop in a for loop, we can make a map with senderId as keys and display name as values and then loop through each participant by checking the map for a display name.
Right now it is O(P x M) were P is the number of participants and M is the number of messages. With this optimization, it would improve to O(P + M).
What
Fix for OnFetchProfile display name in chat for Teams user
Why
https://skype.visualstudio.com/SPOOL/_workitems/edit/4171189
How Tested
Process & policy checklist
Is this a breaking change?