Skip to content

[A11y]Change role to dialog to fix accessible name for effects pane #5937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 16, 2025

Conversation

prabhjot-msft
Copy link
Contributor

What

[A11y]Change role to dialog to fix accessible name for effects pane

Why

https://skype.visualstudio.com/SPOOL/_queries/edit/3832365/?queryId=b6ea9791-8605-4d46-840c-f240e55fd13d

How Tested

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

Copy link
Contributor

Copy link
Contributor

github-actions bot commented Jul 16, 2025

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 58392 / 94972
61.48%
58392 / 94972
61.48%
1187 / 2716
43.7%
3388 / 5776
58.65%
Current 58358 / 94972
61.44%
58358 / 94972
61.44%
1187 / 2716
43.7%
3385 / 5777
58.59%
Diff -34 / 0
-0.04%
-34 / 0
-0.04%
0 / 0
0%
-3 / 1
-0.06%

Copy link
Contributor

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 29660 / 47353
62.63%
29660 / 47353
62.63%
816 / 1493
54.65%
2420 / 3855
62.77%
Current 29660 / 47353
62.63%
29660 / 47353
62.63%
816 / 1493
54.65%
2420 / 3855
62.77%
Diff 0 / 0
0%
0 / 0
0%
0 / 0
0%
0 / 0
0%

@prabhjot-msft prabhjot-msft enabled auto-merge (squash) July 16, 2025 21:37
Copy link
Contributor

📦 CallWithChat bundle size

Bundle Base Size (bytes) Current Size (bytes) Change Delta (bytes)
build.bundle.js 7581572 7581568 ⬇️ decreased -4
398.bundle.js 12413613 12413613 ➖ unchanged 0
399.bundle.js 362460 362460 ➖ unchanged 0
450.bundle.js 4510 4510 ➖ unchanged 0
82.bundle.js 28357 28357 ➖ unchanged 0
91.bundle.js 4158 4158 ➖ unchanged 0

Total change: -4 B ⬇️

Copy link
Contributor

📦 Calling bundle size

Bundle Base Size (bytes) Current Size (bytes) Change Delta (bytes)
build.bundle.js 6605853 6605849 ⬇️ decreased -4
398.bundle.js 12413599 12413599 ➖ unchanged 0

Total change: -4 B ⬇️

Copy link
Contributor

📦 Chat bundle size

Bundle Base Size (bytes) Current Size (bytes) Change Delta (bytes)
build.bundle.js 1781126 1781126 ➖ unchanged 0
110.bundle.js 365728 365728 ➖ unchanged 0
450.bundle.js 4494 4494 ➖ unchanged 0
82.bundle.js 28341 28341 ➖ unchanged 0
91.bundle.js 4142 4142 ➖ unchanged 0

Total change: +0 B ➖

Copy link
Contributor

@prabhjot-msft prabhjot-msft merged commit 9a74b2e into main Jul 16, 2025
41 checks passed
@prabhjot-msft prabhjot-msft deleted the prabhjot/ezra-ally branch July 16, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants