Terraform provider configuration errors and role assignment output reference

[joseguzman1337]

Overview/Summary

This Pull Request resolves Terraform configuration issues that caused errors and warnings during terraform plan. It corrects provider-passing logic between the root module and child modules (management, identity, connectivity) and fixes an incorrect resource reference within the role_assignments_for_policy module's outputs. These changes ensure the Terraform configuration plans successfully and adheres to best practices for provider configuration.

This PR fixes/adds/changes/removes

1. Fix: Corrected the providers block in main.tf for management_resources, identity_resources, and connectivity_resources modules to pass the default azurerm provider instead of attempting to pass a non-existent azurerm.subscription alias. Resolves Error: missing provider provider[".../azurerm"].subscription.
2. Fix: Updated required_providers blocks within the management, identity, and connectivity child modules to explicitly declare expected provider aliases (e.g., azurerm.management, azurerm.subscription) using configuration_aliases. Resolves Warning: Reference to undefined provider.
3. Fix: Corrected the resource reference in outputs.tf within the role_assignments_for_policy module to accurately point to the intended azurerm_role_assignment resource or handle its potential absence gracefully. Resolves Error: Reference to undeclared resource.

Breaking Changes

1. None

Testing Evidence

As part of this Pull Request I have

• Checked for duplicate Pull Requests
• Associated it with relevant issues, for tracking and closure.
• Ensured my code/branch is up-to-date with the latest changes in the main branch
• Performed testing and provided evidence.
• Updated relevant and associated documentation.

[matt-FFFFFF]

Hi this PR seems to have lots of files that we don't want in this repo. Please can you refactor?