Skip to content

11 clean up fenics and kratos example #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jul 25, 2025

Conversation

srosenbu
Copy link
Member

@srosenbu srosenbu commented Jul 14, 2025

Mostly making the einput creation of Kratos modular because the previous version was just a large python script.
Furthermore, the input files for Kratos are now defined as json files with placeholders "{{PLACEHOLDER}}" that are replaced by a certain value in the create_input_files.py.

Todo:

  • [ ] Describe the benchmark in the docs (still waiting for the source from the library)

@srosenbu srosenbu linked an issue Jul 14, 2025 that may be closed by this pull request
@srosenbu srosenbu marked this pull request as ready for review July 15, 2025 10:54
@srosenbu srosenbu requested review from joergfunger and div-tyg July 15, 2025 10:54
Copy link
Member

@joergfunger joergfunger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work, let's try to remove the binary stuff

@srosenbu srosenbu requested a review from joergfunger July 25, 2025 11:23
Copy link
Member

@joergfunger joergfunger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

final comment would be making the tools the latest level in the benchmark hierarchy, the rest is perfectly fine and can be merged

@srosenbu srosenbu merged commit 1dded98 into main Jul 25, 2025
2 checks passed
@srosenbu srosenbu deleted the 11-clean-up-fenics-and-kratos-example branch July 25, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up fenics and kratos example
2 participants