-
Notifications
You must be signed in to change notification settings - Fork 2
11 clean up fenics and kratos example #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work, let's try to remove the binary stuff
benchmarks/linear-elasticity-plate-with-hole-Kratos/input_template.json
Outdated
Show resolved
Hide resolved
benchmarks/linear-elasticity-plate-with-hole-Kratos/StructuralMaterials_template.json
Outdated
Show resolved
Hide resolved
benchmarks/linear-elasticity-plate-with-hole/summary_003125.json
Outdated
Show resolved
Hide resolved
benchmarks/linear-elasticity-plate-with-hole/data/output_003125_p0_000000.vtu
Outdated
Show resolved
Hide resolved
benchmarks/linear-elasticity-plate-with-hole-Kratos/create_input_files.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
final comment would be making the tools the latest level in the benchmark hierarchy, the rest is perfectly fine and can be merged
Mostly making the einput creation of Kratos modular because the previous version was just a large python script.
Furthermore, the input files for Kratos are now defined as json files with placeholders
"{{PLACEHOLDER}}"
that are replaced by a certain value in thecreate_input_files.py
.Todo:
[ ] Describe the benchmark in the docs (still waiting for the source from the library)